[GitHub] [spark] hvanhovell commented on a diff in pull request #40346: [SPARK-42667][CONNECT][FOLLOW-UP] SparkSession created by newSession should not share the channel

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40346:
URL: https://github.com/apache/spark/pull/40346#discussion_r1130235365


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -164,7 +165,7 @@ private[sql] class SparkConnectClient(
   }
 
   def copy(): SparkConnectClient = {
-    new SparkConnectClient(userContext, channel, userAgent)
+    SparkConnectClient.builder().connectionString(connectString).build()

Review Comment:
   Only works if you only use a connection string right? So what about SSL, or when the host and port are set manually? Can't we just pass the ChannelBuilder around?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org