You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/09/19 13:28:08 UTC
[GitHub] [myfaces] melloware opened a new pull request #224: MYFACES-4412: Add new layout="list"
melloware opened a new pull request #224:
URL: https://github.com/apache/myfaces/pull/224
MYFACES-4412: Add new layout="list" attribute value to h:selectManyCheckbox and h:selectOneRadio so it renders <ul> instead of <table>
Also the "border" attribute was being completely ignored and always set to "0". Followed Mojarra's example for this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #224: MYFACES-4412: Add new layout="list"
Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #224:
URL: https://github.com/apache/myfaces/pull/224#issuecomment-922481147
code looks good, thanks
i assume you did a short test of the modes? if yes, please merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #224: MYFACES-4412: Add new layout="list"
Posted by GitBox <gi...@apache.org>.
melloware merged pull request #224:
URL: https://github.com/apache/myfaces/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #224: MYFACES-4412: Add new layout="list"
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #224:
URL: https://github.com/apache/myfaces/pull/224#issuecomment-922488920
I am still running a few tests but wanted your eyes on it in case you didn't like anything about it. I followed what BalusC did for mojarra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #224: MYFACES-4412: Add new layout="list"
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #224:
URL: https://github.com/apache/myfaces/pull/224#issuecomment-922498964
Reproducer with screenshot and verified HTML is correct for all 3 types
[MYFACES-4412.zip](https://github.com/apache/myfaces/files/7192472/MYFACES-4412.zip)
I don't have merge permissions yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org