You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by cc...@apache.org on 2018/10/17 00:45:09 UTC

[incubator-superset] branch chris--ajax-sqllab created (now 5cb32c1)

This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a change to branch chris--ajax-sqllab
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at 5cb32c1  [cypress][sqllab][superset-client] fix

This branch includes the following new commits:

     new 5cb32c1  [cypress][sqllab][superset-client] fix

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-superset] 01/01: [cypress][sqllab][superset-client] fix

Posted by cc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ccwilliams pushed a commit to branch chris--ajax-sqllab
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 5cb32c131bcdb0cafe8d7c2ebd00b8ed5a4f50ec
Author: Chris Williams <ch...@airbnb.com>
AuthorDate: Tue Oct 16 17:44:52 2018 -0700

    [cypress][sqllab][superset-client] fix
---
 superset/assets/cypress/integration/sqllab/query.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/assets/cypress/integration/sqllab/query.js b/superset/assets/cypress/integration/sqllab/query.js
index 0f52039..40bbd0d 100644
--- a/superset/assets/cypress/integration/sqllab/query.js
+++ b/superset/assets/cypress/integration/sqllab/query.js
@@ -40,6 +40,7 @@ export default () => {
 
     it('successfully saves a query', () => {
       cy.route('savedqueryviewapi/**').as('getSavedQuery');
+      cy.route('superset/tables/**').as('getTables');
 
       const query = 'SELECT ds, gender, name, num FROM main.birth_names ORDER BY name LIMIT 3';
       const savedQueryTitle = `CYPRESS TEST QUERY ${shortid.generate()}`;
@@ -83,7 +84,7 @@ export default () => {
       cy.get('table tr:first-child a[href*="savedQueryId"').click();
 
       // will timeout without explicitly waiting here
-      cy.wait('@getSavedQuery');
+      cy.wait(['@getSavedQuery', '@getTables']);
 
       // run the saved query
       cy.get('#js-sql-toolbar button')