You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/04/15 18:12:38 UTC
[GitHub] [openwhisk] rabbah opened a new pull request #4883: Skip travis
jobs if pr only touches docs.
rabbah opened a new pull request #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883
Exclude travis jobs if a PR only touches documentation. Only scan code will run.
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4883: Skip travis jobs
if pr only touches docs.
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883#issuecomment-614314430
If we want to optimize for quick merge of documentation-only PRs, we should probably short-circuit the step of the build that compiles & deploys openwhisk too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4883: Skip travis jobs if pr
only touches docs.
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883#issuecomment-614394296
Can we merge this to see if this approach will actually work? It will already be an improvement. Some of the earlier steps will need to be moved into bash scripts - there's no way that i found to exclude travis steps/jobs because it doesn't evaluate true conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4883: Skip travis jobs
if pr only touches docs.
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883#issuecomment-614644696
don't object to merging; just observing that as-is it creates 7 jobs, each of which will run for about 8 minutes (mainly due to the setup script).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4883: Skip travis jobs if pr
only touches docs.
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883#issuecomment-614922057
Not working as intended - the build should have been normal but all the tests are being skipped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4883: Skip travis jobs if pr
only touches docs.
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4883: Skip travis jobs if pr only touches docs.
URL: https://github.com/apache/openwhisk/pull/4883#issuecomment-614266705
@dgrove-oss wdyt about merging this PR.
I will test it out on #4880. The intent is to skip tests for md related changes and only run scancode.
I left perf tests enabled in this PR intentionally to see if it works as designed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services