You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/06 07:17:55 UTC
[GitHub] [ignite] ptupitsyn opened a new pull request, #10069: IGNITE-17063 .NET: Improve Java detection on Linux
ptupitsyn opened a new pull request, #10069:
URL: https://github.com/apache/ignite/pull/10069
* Try `/usr/bin/readlink` as well as `readlink` - it is not in PATH in some rare scenarios.
* Improve logging when commands fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10069: IGNITE-17063 .NET: Improve Java detection on Linux
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10069:
URL: https://github.com/apache/ignite/pull/10069#discussion_r890799871
##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/ShellTests.cs:
##########
@@ -17,38 +17,82 @@
namespace Apache.Ignite.Core.Tests
{
+ using System;
+ using System.Linq;
using Apache.Ignite.Core.Impl;
- using Apache.Ignite.Core.Impl.Unmanaged;
+ using Apache.Ignite.Core.Log;
+ using Apache.Ignite.Core.Tests.Client.Cache;
using NUnit.Framework;
/// <summary>
/// Tests for <see cref="Shell"/> class.
/// </summary>
+ [Platform("Linux")]
+ [Order(1)] // Execute first to avoid zombie processes (see https://issues.apache.org/jira/browse/IGNITE-13536).
public class ShellTests
{
/// <summary>
/// Tests <see cref="Shell.ExecuteSafe"/> method.
/// </summary>
[Test]
- public void TestExecuteSafe()
+ public void TestExecuteSafeReturnsStdout()
Review Comment:
It means that `ExecuteSafe` method returns whatever the executed command writes to [Standard output (stdout)](https://en.wikipedia.org/wiki/Standard_streams#Standard_output_(stdout)) as a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a diff in pull request #10069: IGNITE-17063 .NET: Improve Java detection on Linux
Posted by GitBox <gi...@apache.org>.
isapego commented on code in PR #10069:
URL: https://github.com/apache/ignite/pull/10069#discussion_r890438234
##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/ShellTests.cs:
##########
@@ -17,38 +17,82 @@
namespace Apache.Ignite.Core.Tests
{
+ using System;
+ using System.Linq;
using Apache.Ignite.Core.Impl;
- using Apache.Ignite.Core.Impl.Unmanaged;
+ using Apache.Ignite.Core.Log;
+ using Apache.Ignite.Core.Tests.Client.Cache;
using NUnit.Framework;
/// <summary>
/// Tests for <see cref="Shell"/> class.
/// </summary>
+ [Platform("Linux")]
+ [Order(1)] // Execute first to avoid zombie processes (see https://issues.apache.org/jira/browse/IGNITE-13536).
public class ShellTests
{
/// <summary>
/// Tests <see cref="Shell.ExecuteSafe"/> method.
/// </summary>
[Test]
- public void TestExecuteSafe()
+ public void TestExecuteSafeReturnsStdout()
Review Comment:
What does "ReturnsStdout" mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #10069: IGNITE-17063 .NET: Improve Java detection on Linux
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged PR #10069:
URL: https://github.com/apache/ignite/pull/10069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org