You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2009/12/28 20:43:29 UTC
[jira] Created: (LUCENE-2185) add @Deprecated annotations
add @Deprecated annotations
---------------------------
Key: LUCENE-2185
URL: https://issues.apache.org/jira/browse/LUCENE-2185
Project: Lucene - Java
Issue Type: Task
Reporter: Robert Muir
Priority: Trivial
Fix For: 3.1
as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2185) add @Deprecated annotations
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2185:
--------------------------------
Fix Version/s: Flex Branch
Committed revision 895342 to trunk.
I added flex branch here, after the next time trunk is merged to it we should do the same there.
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Trivial
> Fix For: Flex Branch, 3.1
>
> Attachments: LUCENE-2185.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2185) add @Deprecated annotations
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2185.
---------------------------------
Resolution: Fixed
Committed revision 899831 to flex
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Trivial
> Fix For: Flex Branch, 3.1
>
> Attachments: LUCENE-2185.patch, LUCENE-2185_flex.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2185) add @Deprecated annotations
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2185:
--------------------------------
Attachment: LUCENE-2185_flex.patch
patch for flex, also RegexTermsEnum is undeprecated as it was accidentally deprecated in favor of itself.
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Trivial
> Fix For: Flex Branch, 3.1
>
> Attachments: LUCENE-2185.patch, LUCENE-2185_flex.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2185) add @Deprecated annotations
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795340#action_12795340 ]
Steven Rowe commented on LUCENE-2185:
-------------------------------------
The justification for using @Deprecated, AFAICT, is that conforming compilers are required to issue warnings for each so-annotated class/method, where compilers are *not* required to issue warnings for javadoc @deprecated tags, and although Sun compilers do this, other vendors' compilers might not.
Another (similarly theoretical) argument in favor of using @Deprecated annotations is that, unlike @deprecated javadoc tags, this annotation is available via runtime reflection.
A random information point: MYFACES-2135 removed all @Deprecated annotations from MyFaces code because an apparent bug in the Sun TCK flags methods bearing this annotation as changing method signatures.
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2185.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2185) add @Deprecated annotations
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-2185:
-------------------------------
Attachment: LUCENE-2185.patch
Attaching patch for Robert.
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2185.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2185) add @Deprecated annotations
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reassigned LUCENE-2185:
-----------------------------------
Assignee: Robert Muir
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2185.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2185) add @Deprecated annotations
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795342#action_12795342 ]
Robert Muir commented on LUCENE-2185:
-------------------------------------
Steven, yeah i know theoretically why this is here, but it is completely stupid.
@Deprecated is a gigantic mistake, requiring me to write it twice, once lowercase in the javadocs, once uppercase as an annotation. This is the only way to properly deprecate something with a message as to why.
and so this additional work buys me nothing, except some theoretical workaround to sun's piss-poor broken language design.
this being said, i still think we should be consistent: either remove all these annotations or add them all, and not just use them 'sometime'.
> add @Deprecated annotations
> ---------------------------
>
> Key: LUCENE-2185
> URL: https://issues.apache.org/jira/browse/LUCENE-2185
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2185.patch
>
>
> as discussed on LUCENE-2084, I think we should be consistent about use of @Deprecated annotations if we are to use it.
> This patch adds the missing annotations... unfortunately i cannot commit this for some time, because my internet connection does not support heavy committing (it is difficult to even upload a large patch).
> So if someone wants to take it, have fun, otherwise in a week or so I will commit it if nobody objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org