[GitHub] [doris] Tanya-W commented on a diff in pull request #16226: [fix](inverted index) fix some bug about fulltext match query with compound conditions

["Tanya-W (via GitHub)" <gi...@apache.org>]

Tanya-W commented on code in PR #16226:
URL: https://github.com/apache/doris/pull/16226#discussion_r1091416847


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -466,8 +466,12 @@ Status SegmentIterator::_execute_predicates_except_leafnode_of_andnode(vectorize
     } else if (_is_literal_node(node_type)) {
         auto v_literal_expr = dynamic_cast<doris::vectorized::VLiteral*>(expr);
         _column_predicate_info->query_value = v_literal_expr->value();
-    } else if (node_type == TExprNodeType::BINARY_PRED) {

Review Comment:
   The only difference between `BINARY_PRED` and `MATCH_PRED` branch is `query_op` is different, use another "else if" will be some duplicate code.
   Specify `MATCH_PRED`'s query_op as "match" not `expr->fn().name.function_name` in order to unify "match_any", "match_all" and so on to "match"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org