[jira] [Commented] (SCM-939) Assume SCM is present

["Elliotte Rusty Harold (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCM-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104457#comment-17104457 ] 

Elliotte Rusty Harold commented on SCM-939:
-------------------------------------------

This is tricky because Maven incorrectly treats an assumption violation as an error. The assumption violation gets wrapped in a MojoFailureException. 

 

[ERROR] Errors: 
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 » AssumptionViolated
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 » AssumptionViolated
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 » AssumptionViolated
[ERROR] CvsExeCheckoutCommandTest>CvsCheckoutCommandTest.setUp:50 » AssumptionViolated
[ERROR] CvsExeCheckoutCommandTest>CvsCheckoutCommandTest.setUp:50 » AssumptionViolated
[ERROR] CvsExeUpdateCommandTest>CvsUpdateCommandTest.setUp:59 » AssumptionViolated got...
[INFO] 
[ERROR] Tests run: 7, Failures: 0, Errors: 6, Skipped: 0
[INFO]

> Assume SCM is present
> ---------------------
>
>                 Key: SCM-939
>                 URL: https://issues.apache.org/jira/browse/SCM-939
>             Project: Maven SCM
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Minor
>
> We have a lot of tests that do something like this:
>  
> if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
>  {
>  ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
>  return;
>  }
>  
> We should instead use org.*junit*.*Assume* here so these are marked as skipped rather than passed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)