[GitHub] [kafka] ccding commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

[GitBox <gi...@apache.org>]

ccding commented on a change in pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#discussion_r668981421



##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -96,6 +98,45 @@ case class LogConfig(props: java.util.Map[_, _], overriddenConfigs: Set[String]
   val LeaderReplicationThrottledReplicas = getList(LogConfig.LeaderReplicationThrottledReplicasProp)
   val FollowerReplicationThrottledReplicas = getList(LogConfig.FollowerReplicationThrottledReplicasProp)
   val messageDownConversionEnable = getBoolean(LogConfig.MessageDownConversionEnableProp)
+  val remoteStorageEnable = getBoolean(LogConfig.RemoteLogStorageEnableProp)

Review comment:
       Why do we use `remoteStorageEnable` but are using `RemoteLogStorageEnable` in the following place
   https://github.com/satishd/kafka/blob/6e66695e87c8dd7db33cb134e83e0281e2216a62/core/src/main/scala/kafka/log/LogConfig.scala#L43
   
   Should we rename is to `remoteLogStorageEnable`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org