You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Balazs Hevele (Code Review)" <ge...@cloudera.org> on 2026/03/09 12:00:32 UTC

[Impala-ASF-CR] IMPALA-12137: do not copy parquet data for dict encoded pages

Balazs Hevele has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24080


Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages
......................................................................

IMPALA-12137: do not copy parquet data for dict encoded pages

For dict encoded pages, strings will point to the dictionary, and not
the data page, so there is no need to make a copy of the page data in
this case.

Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
---
M be/src/exec/parquet/parquet-column-chunk-reader.cc
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/24080/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 1
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc
File be/src/exec/parquet/parquet-column-chunk-reader.cc:

http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc@387
PS1, Line 387: lueMemoryType::VAR_LEN_STR) &&
             :       
> Shouldn't this be the opposite, so each case when it is not dictionary enco
You're absolutely right! Fixed.



-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 17:38:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13211/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 17:39:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................

IMPALA-12137: Do not copy parquet data for dict encoded pages

For dict encoded pages, strings will point to the dictionary, and not
the data page, so there is no need to make a copy of the page data in
this case.

Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Reviewed-on: http://gerrit.cloudera.org:8080/24080
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-column-chunk-reader.cc
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 5
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 4
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:42:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/21968/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 3
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:59:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13210/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 1
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:01:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24080/2/be/src/exec/parquet/parquet-column-chunk-reader.cc
File be/src/exec/parquet/parquet-column-chunk-reader.cc:

http://gerrit.cloudera.org:8080/#/c/24080/2/be/src/exec/parquet/parquet-column-chunk-reader.cc@388
PS2, Line 388:   
nit: requires +4 indent



-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:01:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12137: do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13210/


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 1
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 16:25:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 4
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 18:08:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21895/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 18:05:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24080/2/be/src/exec/parquet/parquet-column-chunk-reader.cc
File be/src/exec/parquet/parquet-column-chunk-reader.cc:

http://gerrit.cloudera.org:8080/#/c/24080/2/be/src/exec/parquet/parquet-column-chunk-reader.cc@388
PS2, Line 388:   
> nit: requires +4 indent
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 3
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:33:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12137: do not copy parquet data for dict encoded pages

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc
File be/src/exec/parquet/parquet-column-chunk-reader.cc:

http://gerrit.cloudera.org:8080/#/c/24080/1/be/src/exec/parquet/parquet-column-chunk-reader.cc@387
PS1, Line 387: lueMemoryType::VAR_LEN_STR) &&
             :       
Shouldn't this be the opposite, so each case when it is not dictionary encoded?



-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 1
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 13:10:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 21:56:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: do not copy parquet data for dict encoded pages
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21894/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 1
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:25:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13240/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 4
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:42:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24080

to look at the new patch set (#3).

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................

IMPALA-12137: Do not copy parquet data for dict encoded pages

For dict encoded pages, strings will point to the dictionary, and not
the data page, so there is no need to make a copy of the page data in
this case.

Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
---
M be/src/exec/parquet/parquet-column-chunk-reader.cc
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/24080/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 3
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24080 )

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................


Patch Set 3: Code-Review+2

LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 3
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 13:42:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12137: Do not copy parquet data for dict encoded pages

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24080

to look at the new patch set (#2).

Change subject: IMPALA-12137: Do not copy parquet data for dict encoded pages
......................................................................

IMPALA-12137: Do not copy parquet data for dict encoded pages

For dict encoded pages, strings will point to the dictionary, and not
the data page, so there is no need to make a copy of the page data in
this case.

Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
---
M be/src/exec/parquet/parquet-column-chunk-reader.cc
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/24080/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3debd1d8e6b8825723b0d3f4aa82190b2cac1e0e
Gerrit-Change-Number: 24080
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>