You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "Akshat-Jain (via GitHub)" <gi...@apache.org> on 2024/12/18 04:03:42 UTC
[PR] Revert `UnnecessaryFullyQualifiedName` pmd rule (druid)
Akshat-Jain opened a new pull request, #17584:
URL: https://github.com/apache/druid/pull/17584
### Description
This PR reverts https://github.com/apache/druid/commit/cd6083fb9423260e46876bfb3f4527c3581a9cb9 as per further inputs on the PR changes: https://github.com/apache/druid/pull/17570#issuecomment-2550264237.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert `UnnecessaryFullyQualifiedName` pmd rule (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #17584:
URL: https://github.com/apache/druid/pull/17584#discussion_r1889599958
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/AvroSchemaRegistryEventSerializer.java:
##########
@@ -73,7 +73,7 @@
try {
RetryUtils.retry(
() -> {
- schemaId = client.register(topic, SCHEMA);
+ schemaId = client.register(topic, AvroEventSerializer.SCHEMA);
Review Comment:
## Deprecated method or constructor invocation
Invoking [SchemaRegistryClient.register](1) should be avoided because it has been deprecated.
[Show more details](https://github.com/apache/druid/security/code-scanning/707)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert `UnnecessaryFullyQualifiedName` pmd rule (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #17584:
URL: https://github.com/apache/druid/pull/17584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org