You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/08 20:23:36 UTC
[kudu-CR] [doc] updated release notes for Kudu C++ client
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5006
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
[doc] updated release notes for Kudu C++ client
Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
---
M docs/release_notes.adoc
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/5006/1
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5006
to look at the new patch set (#2).
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
[doc] updated release notes for Kudu C++ client
Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/5006/2
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5006/3/docs/release_notes.adoc
File docs/release_notes.adoc:
PS3, Line 70:
extra space here
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5006
to look at the new patch set (#3).
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
[doc] updated release notes for Kudu C++ client
Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/5006/3
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5006/3/docs/release_notes.adoc
File docs/release_notes.adoc:
PS3, Line 70:
> extra space here
Done
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5006/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 70: {cpp} client API
Nit: can you format this like the first point? Something like "The {cpp} client's KuduSession::CountBufferedOperations() method...".
PS1, Line 71: as deprecated
Instead of "marked as deprecated", just say "deprecated".
PS1, Line 72: Besides, it's possible to count number of buffered
: operations by a different means.
Let's be more direct. "Instead, count the number of buffered operations by ..."
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5006/2/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 62:
> Nit: the three bullet points refer to a client as either a "<language> clie
Done. I think your choice is the best.
PS2, Line 74: or invocation of the callback passed into KuduSession::FlushAsync()
> Nit: "or, if using asynchronous flushing, since last invocation of the call
Done
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
[doc] updated release notes for Kudu C++ client
Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Reviewed-on: http://gerrit.cloudera.org:8080/5006
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5006/2/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 62:
Nit: the three bullet points refer to a client as either a "<language> client library", a "<language> client API", or a "<language> client". We should consolidate behind two of those if not just one. I'd personally vote for the last one as it's the shortest, but I'll defer to your judgment.
PS2, Line 74: or invocation of the callback passed into KuduSession::FlushAsync()
Nit: "or, if using asynchronous flushing, since last invocation of the callback passed into KuduSession::FlushAsync()).
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5006/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 70: {cpp} client API
> Nit: can you format this like the first point? Something like "The {cpp} cl
Done
PS1, Line 71: as deprecated
> Instead of "marked as deprecated", just say "deprecated".
Done
PS1, Line 72: Besides, it's possible to count number of buffered
: operations by a different means.
> Let's be more direct. "Instead, count the number of buffered operations by
Done
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] updated release notes for Kudu C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5006
to look at the new patch set (#4).
Change subject: [doc] updated release notes for Kudu C++ client
......................................................................
[doc] updated release notes for Kudu C++ client
Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/5006/4
--
To view, visit http://gerrit.cloudera.org:8080/5006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins