You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2017/08/10 23:43:37 UTC
Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/
-----------------------------------------------------------
Review request for atlas, David Radley and Madhan Neethiraj.
Bugs: ATLAS-2040
https://issues.apache.org/jira/browse/ATLAS-2040
Repository: atlas
Description
-------
Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
Add more unit tests to test these cases
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
Diff: https://reviews.apache.org/r/61589/diff/1/
Testing
-------
* added new UTs to test many-to-many relationships on same attribute name/same type
* added new UTs to test one-to-one relationships on same attribute name/same type
* mvn clean install -DskipITs=true suceeded without any failures
Thanks,
Sarath Subramanian
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review184016
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java
Line 133 (original), 140 (patched)
<https://reviews.apache.org/r/61589/#comment260031>
When both ends have the same type and name, perhaps we should require second end to be not specified in relationship def? This can help avoid duplicate end-def.
- Madhan Neethiraj
On Aug. 28, 2017, 11:26 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 11:26 p.m.)
>
>
> Review request for atlas, David Radley and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type is specified at both ends.
>
> For e.g. employee-friends type where same attribute 'friends' in type 'Employee' is specified at both ends
>
> Add more unit tests to test these cases
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 3de02d08
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 6f30ff35
> intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0177f7e4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java fbb98584
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4e7aa473
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
>
>
> Diff: https://reviews.apache.org/r/61589/diff/4/
>
>
> Testing
> -------
>
> * added new UTs to test many-to-many relationships on same attribute name/same type
> * added new UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/
-----------------------------------------------------------
(Updated Aug. 28, 2017, 4:26 p.m.)
Review request for atlas, David Radley and Madhan Neethiraj.
Changes
-------
rebased with latest from master
Bugs: ATLAS-2040
https://issues.apache.org/jira/browse/ATLAS-2040
Repository: atlas
Description
-------
Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
Add more unit tests to test these cases
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 3de02d08
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 6f30ff35
intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0177f7e4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java fbb98584
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4e7aa473
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
Diff: https://reviews.apache.org/r/61589/diff/4/
Changes: https://reviews.apache.org/r/61589/diff/3-4/
Testing
-------
* added new UTs to test many-to-many relationships on same attribute name/same type
* added new UTs to test one-to-one relationships on same attribute name/same type
* mvn clean install -DskipITs=true suceeded without any failures
Thanks,
Sarath Subramanian
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/
-----------------------------------------------------------
(Updated Aug. 23, 2017, 10:28 a.m.)
Review request for atlas, David Radley and Madhan Neethiraj.
Changes
-------
rebased patch.
Bugs: ATLAS-2040
https://issues.apache.org/jira/browse/ATLAS-2040
Repository: atlas
Description
-------
Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
Add more unit tests to test these cases
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 3de02d08
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4304e745
intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0177f7e4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 4e7aa473
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
Diff: https://reviews.apache.org/r/61589/diff/3/
Changes: https://reviews.apache.org/r/61589/diff/2-3/
Testing
-------
* added new UTs to test many-to-many relationships on same attribute name/same type
* added new UTs to test one-to-one relationships on same attribute name/same type
* mvn clean install -DskipITs=true suceeded without any failures
Thanks,
Sarath Subramanian
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182700
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
Line 18 (original), 18 (patched)
<https://reviews.apache.org/r/61589/#comment258682>
The testing indicated that buuild works with skipIts. Does this means that it breaks some tests asis ?
- David Radley
On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 7:33 a.m.)
>
>
> Review request for atlas, David Radley and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
> Add more unit tests to test these cases
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
>
>
> Diff: https://reviews.apache.org/r/61589/diff/2/
>
>
> Testing
> -------
>
> * added new UTs to test many-to-many relationships on same attribute name/same type
> * added new UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182690
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 130 (patched)
<https://reviews.apache.org/r/61589/#comment258675>
It should be BOTH for associations with different names on each end as well
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Line 126 (original), 135 (patched)
<https://reviews.apache.org/r/61589/#comment258672>
I suggest the default is BOTH. We give it a direction for specific cases.
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Line 127 (original), 136 (patched)
<https://reviews.apache.org/r/61589/#comment258674>
We should support BOTH for association relationships.
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 386 (original), 392 (patched)
<https://reviews.apache.org/r/61589/#comment258681>
this has lost its indentation
- David Radley
On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 7:33 a.m.)
>
>
> Review request for atlas, David Radley and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
> Add more unit tests to test these cases
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
>
>
> Diff: https://reviews.apache.org/r/61589/diff/2/
>
>
> Testing
> -------
>
> * added new UTs to test many-to-many relationships on same attribute name/same type
> * added new UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182702
-----------------------------------------------------------
- David Radley
On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 7:33 a.m.)
>
>
> Review request for atlas, David Radley and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
> Add more unit tests to test these cases
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
>
>
> Diff: https://reviews.apache.org/r/61589/diff/2/
>
>
> Testing
> -------
>
> * added new UTs to test many-to-many relationships on same attribute name/same type
> * added new UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/
-----------------------------------------------------------
(Updated Aug. 11, 2017, 12:33 a.m.)
Review request for atlas, David Radley and Madhan Neethiraj.
Changes
-------
addressed review comments.
Bugs: ATLAS-2040
https://issues.apache.org/jira/browse/ATLAS-2040
Repository: atlas
Description
-------
Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
Add more unit tests to test these cases
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
Diff: https://reviews.apache.org/r/61589/diff/2/
Changes: https://reviews.apache.org/r/61589/diff/1-2/
Testing
-------
* added new UTs to test many-to-many relationships on same attribute name/same type
* added new UTs to test one-to-one relationships on same attribute name/same type
* mvn clean install -DskipITs=true suceeded without any failures
Thanks,
Sarath Subramanian
Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many
cardinality gives incorrect relationship attribute value
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182661
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 30 (patched)
<https://reviews.apache.org/r/61589/#comment258640>
Consider replacing org.jboss.netty.util.internal.StringUtil usage with org.apache.commons.lang.StringUtils.
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 1352 (original), 1359 (patched)
<https://reviews.apache.org/r/61589/#comment258641>
Shouldn't this also handle AtlasRelationshipEdgeDirection.BOTH?
- Madhan Neethiraj
On Aug. 10, 2017, 11:43 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 11:43 p.m.)
>
>
> Review request for atlas, David Radley and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Relationship with many-to-many cardinality gives incorrect relationship attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of relationship definition. Creating new relationships fails to retireve the right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified at both ends
> Add more unit tests to test these cases
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 42713763
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java b8fd70e5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 667c61bd
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java 2c311403
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java 33ef8c0f
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java a35647dc
>
>
> Diff: https://reviews.apache.org/r/61589/diff/1/
>
>
> Testing
> -------
>
> * added new UTs to test many-to-many relationships on same attribute name/same type
> * added new UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
>
>
> Thanks,
>
> Sarath Subramanian
>
>