You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/06 13:20:18 UTC
[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #476: [YUNIKORN-1389] Pass node labels from shim to core
zhuqi-lucas opened a new pull request, #476:
URL: https://github.com/apache/yunikorn-k8shim/pull/476
### What is this PR for?
Suggested by [YUNIKORN-1362](https://issues.apache.org/jira/browse/YUNIKORN-1362):
The YuniKorn UI shows the list of all the nodes in the cluster. There is no way of filtering the list.
We have only certain nodes that we want our jobs to be scheduled in the cluster and that is dictated by the nodeSelector. I would good to have a way to show only those nodes on the UI to give a better idea of the resources that we have for the jobs to be scheduled
The functionality will depend on the details we pull for the nodes into the core. Propagating some info for a node from the shim into the core might be needed.
Here we first to pass node labels from shim to core.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #476: [YUNIKORN-1389] Pass node labels from shim to core
Posted by GitBox <gi...@apache.org>.
pbacsko commented on PR #476:
URL: https://github.com/apache/yunikorn-k8shim/pull/476#issuecomment-1320302562
@zhuqi-lucas please rebase this change, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #476: [YUNIKORN-1389] Pass node labels from shim to core
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #476: [YUNIKORN-1389] Pass node labels from shim to core
URL: https://github.com/apache/yunikorn-k8shim/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #476: [YUNIKORN-1389] Pass node labels from shim to core
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #476:
URL: https://github.com/apache/yunikorn-k8shim/pull/476#issuecomment-1304804675
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#476](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70d2854) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/8ff45c33edd7e592d8c752f3eb366c233b66e1b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ff45c3) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 68.03% 68.01% -0.03%
==========================================
Files 42 42
Lines 6921 6922 +1
==========================================
- Hits 4709 4708 -1
- Misses 2042 2044 +2
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/node.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `84.74% <100.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.54% <100.00%> (+0.01%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on pull request #476: [YUNIKORN-1389] Pass node labels from shim to core
Posted by GitBox <gi...@apache.org>.
zhuqi-lucas commented on PR #476:
URL: https://github.com/apache/yunikorn-k8shim/pull/476#issuecomment-1321123456
Thank you, @pbacsko, for reminder, rebased now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org