You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/16 22:26:53 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #5786: [AIRFLOW-5170] Fix encoding pragmas, consistent licences for python files and related pylint fixes

feluelle commented on a change in pull request #5786:  [AIRFLOW-5170] Fix encoding pragmas, consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r314884992
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -618,8 +618,12 @@ as follows:
 3) Fix all the issues reported by pylint
 4) Re-run [scripts/ci/ci_pylint.sh](scripts/ci/ci_pylint.sh)
 5) If you see "success" - submit PR following [Pull Request guidelines](#pull-request-guidelines)
+6) You can refresh periodically [scripts/ci/pylint_todo.txt](scripts/ci/pylint_todo.txt). You can do it by
+   [entering the environment](#entering-bash-shell-in-docker-compose-environment) and running
+   [scripts/ci/in_container/refresh_pylint_todo.sh](scripts/ci/in_container/refresh_pylint_todo.sh).
+   This can take quite some time (especially on MacOS)!
 
-There are following guidelines when fixing pylint errors:
+You can follow this guidelines when fixing pylint errors:
 
 Review comment:
   ```suggestion
   You can follow these guidelines when fixing pylint errors:
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services