You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by tpluck <no...@github.com.INVALID> on 2021/09/11 13:11:52 UTC

[apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

- Adjustments to main repo README.md for readability
- Moved existing wiki docs to `/documents` with added permalinks
- Adjusted `/document/README.md` to accomodate all wiki pages
- Removed CSSJ17.pdf and added it as an external cite link
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359

-- Commit Summary --

  * Fixed main readme
  * Fixed broken doc links
  * Updated documents to house wiki with correct links
  * Update README.md

-- File Changes --

    M Readme.md (345)
    M documents/README.md (30)
    D documents/ccsp17.pdf (0)
    A documents/debugging-a-local-rust-sgx-enclave-in-docker-with-sgx-gdb.md (236)
    A documents/environment-setup.md (139)
    A documents/mitigation-of-intel-sa-00219-in-rust-sgx.md (379)
    A documents/performance-optimization-tips.md (52)
    A documents/public-cloud-for-rust-sgx-development.md (9)
    A documents/setup-gdb-7.11-on-ubuntu-18.04-for-vscode---sgx-gdb-remote-debugging.md (70)
    M documents/sgx_in_mesalock_linux.md (11)
    M documents/sgxtime.md (4)
    A documents/the-world-of-forked-crates.md (40)
    A documents/use-vscode---rls---rust-analysis---sgx-gdb-for-graphic-developing-(not-in-docker).md (81)

-- Patch Links --

https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359.patch
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359

Re: [apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

Posted by tpluck <no...@github.com.INVALID>.
Added requested changes.

I see we already have a `release_notes.md` already, would you like the release summaries seen in the main `Readme.md` added to these?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359#issuecomment-918611045

Re: [apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

Posted by Mingshen Sun <no...@github.com.INVALID>.
> I see we already have a `release_notes.md` already, would you like the release summaries seen in the main `Readme.md` added to these?

I saw you fold the release summary, this is cool. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359#issuecomment-919419421

Re: [apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #359 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359#event-5301898867

Re: [apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

Posted by Mingshen Sun <no...@github.com.INVALID>.
The docs are rendered here: https://teaclave.apache.org/sgx-sdk-docs/

All links in the index page are broken because using absolute path. Can you fix it by changing them to relative path?

For example, change `[Setting up your Development Environment](/documents/environment-setup.md)` to `[Setting up your Development Environment](environment-setup.md)`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359#issuecomment-919490920

Re: [apache/incubator-teaclave-sgx-sdk] First Contribution: Issue #276 (#359)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Thanks @ThomasPluck! I'll help to review the PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/pull/359#issuecomment-917722520