You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/14 02:39:45 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #23556:
[SPARK-26626][SQL] Maximum size for repeatedly substituted aliases in SQL
expressions
HyukjinKwon commented on a change in pull request #23556: [SPARK-26626][SQL] Maximum size for repeatedly substituted aliases in SQL expressions
URL: https://github.com/apache/spark/pull/23556#discussion_r265402165
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -658,7 +658,8 @@ object CollapseProject extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
Is the purpose to give up this rule basically? Why don't we consider using `spark.sql.optimizer.excludedRules`? I think it's more general way to resolve such issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org