You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Thomas Diesler (JIRA)" <ji...@apache.org> on 2009/07/06 10:40:15 UTC

[jira] Updated: (FELIX-1020) Footer redered before content in bundle plugin

     [ https://issues.apache.org/jira/browse/FELIX-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Diesler updated FELIX-1020:
----------------------------------

    Attachment: Screenshot-LogService.png

I attached a screen shot that shows that shows how the footer is rendered at the top of the page instead of the bottom

public class LogServicePlugin extends LogServlet
{
   private static final long serialVersionUID = 1L;

   @Override
   protected String getHeader()
   {
      return PluginHelper.getHeader();
   }

   @Override
   protected void endResponse(HttpServletRequest request, PrintWriter pw)
   {
      String appRoot = (String)request.getAttribute(OsgiManager.ATTR_APP_ROOT);
      String footer = MessageFormat.format(PluginHelper.getFooter(), new Object[]{ appRoot });
      pw.println(footer);
   }
}

> Footer redered before content in bundle plugin
> ----------------------------------------------
>
>                 Key: FELIX-1020
>                 URL: https://issues.apache.org/jira/browse/FELIX-1020
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-1.2.8
>            Reporter: Thomas Diesler
>            Assignee: Carsten Ziegeler
>         Attachments: Screenshot-LogService.png
>
>
> The BundlesServlet incorrectly renders the content like this
>         pw.println( "<div id='plugin_content'/>");
>         Util.startScript( pw );
>         pw.print( "renderBundles(");
>         writeJSON(pw, reqInfo.bundle);
>         pw.println(");" );
>         Util.endScript( pw );
> It should however be 
>         pw.println( "<div id='plugin_content'>");
>         Util.startScript( pw );
>         pw.print( "renderBundles(");
>         writeJSON(pw, reqInfo.bundle);
>         pw.println(");" );
>         Util.endScript( pw );
>         pw.println( "</div");
> The <script> tag should be enclosed in the <div>
> The effect of the bug is that the footer appears before the content 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.