You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2010/09/22 20:08:34 UTC

[jira] Created: (HBASE-3030) The return code of many filesystem operations are not checked

The return code of many filesystem operations are not checked
-------------------------------------------------------------

                 Key: HBASE-3030
                 URL: https://issues.apache.org/jira/browse/HBASE-3030
             Project: HBase
          Issue Type: Bug
          Components: regionserver
            Reporter: dhruba borthakur
            Assignee: dhruba borthakur


The region server makes call delete/rename/mkdir calls to the FileSystem. These calls return true or false depending on whether the operation was performed successfully or not. Region server should check these return values, and either throw an exception or log it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-3030) The return code of many filesystem operations are not checked

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HBASE-3030:
------------------------------------

    Attachment: fsErrorCodeCheck.txt

Check the return status from the FileSystem.delete, rename and mkdir operations. In some cases log it and in other cases throw an Exception.

Can somebody pl review this patch and comment on whether my selection of code paths that throw exceptions are indeed valid?

> The return code of many filesystem operations are not checked
> -------------------------------------------------------------
>
>                 Key: HBASE-3030
>                 URL: https://issues.apache.org/jira/browse/HBASE-3030
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: fsErrorCodeCheck.txt
>
>
> The region server makes call delete/rename/mkdir calls to the FileSystem. These calls return true or false depending on whether the operation was performed successfully or not. Region server should check these return values, and either throw an exception or log it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3030) The return code of many filesystem operations are not checked

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913692#action_12913692 ] 

dhruba borthakur commented on HBASE-3030:
-----------------------------------------

The handling of these errors become all the more important when the Hadoop Namenode fails over from primary to the standby.

> The return code of many filesystem operations are not checked
> -------------------------------------------------------------
>
>                 Key: HBASE-3030
>                 URL: https://issues.apache.org/jira/browse/HBASE-3030
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>
> The region server makes call delete/rename/mkdir calls to the FileSystem. These calls return true or false depending on whether the operation was performed successfully or not. Region server should check these return values, and either throw an exception or log it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HBASE-3030) The return code of many filesystem operations are not checked

Posted by "stack (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-3030.
--------------------------

     Hadoop Flags: [Reviewed]
    Fix Version/s: 0.90.0
       Resolution: Fixed

Committed.  Thanks for the nice patch Dhruba.

> The return code of many filesystem operations are not checked
> -------------------------------------------------------------
>
>                 Key: HBASE-3030
>                 URL: https://issues.apache.org/jira/browse/HBASE-3030
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>             Fix For: 0.90.0
>
>         Attachments: fsErrorCodeCheck.txt
>
>
> The region server makes call delete/rename/mkdir calls to the FileSystem. These calls return true or false depending on whether the operation was performed successfully or not. Region server should check these return values, and either throw an exception or log it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.