You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Otpvondoiats (via GitHub)" <gi...@apache.org> on 2024/10/11 12:41:03 UTC

[PR] examples/bmi160:bmi160 add urob mode example. [nuttx-apps]

Otpvondoiats opened a new pull request, #2691:
URL: https://github.com/apache/nuttx-apps/pull/2691

   ## Summary
   examples/bmi160:bmi160 add urob mode example.
   ## Impact
   N/A
   ## Testing
   
   - Environment:
   
     1.   OS and Version: Ubuntu 20.04.6 LTS x86_64
     2.   GCC Version: 13.1.0
     3.   SIM: ./tools/configure.sh sim:nsh
   
   - Order:
   
     1. ./nuttx 
     2. sixaxis
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/bmi160:bmi160 add urob mode example. [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2691:
URL: https://github.com/apache/nuttx-apps/pull/2691#issuecomment-2407351806

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   The provided PR summary does not meet all of NuttX's requirements. Here's a breakdown:
   
   **What's Missing/Needs Improvement:**
   
   * **Summary:**
       * **Why:**  The summary should clearly state the reason for the change. Is it a new feature request? A bug fix? An optimization? Simply stating "add urob mode example" doesn't explain the motivation.
       * **What/How:**  Provide a concise explanation of what "urob mode" is and how the example demonstrates its functionality. 
   * **Impact:**
       * **N/A is not acceptable.**  Even if you believe there's no impact, you need to justify it. For instance:
           *  **Feature:**  Is "urob mode" a new feature in the BMI160 driver itself, or just a new usage example?  
           * **Hardware/Drivers:**  Does this change rely on any specific BMI160 features or configurations? 
           * **Documentation:** Does this new example require any accompanying documentation updates?
   * **Testing:**
       * **Logs:** "Testing logs" are not simply running the application. You need to provide concrete evidence that the change works.  
           * **Before:** What was the behavior *before* your change (e.g., error message, incorrect output)?
           * **After:** Show the output *after* your change, demonstrating the intended behavior (e.g., correct sensor readings, successful mode switch).
   
   **Example of an Improved Summary & Impact:**
   
   ```
   ## Summary
   
   This PR adds an example to `examples/bmi160` demonstrating the use of the BMI160's "urob mode" (Ultra-low power wake-up on rotation) for motion detection applications. The example configures the sensor to trigger an interrupt on rotation events, showcasing low-power operation.
   
   ## Impact
   
   * **New Feature:** This PR introduces a new example showcasing a specific use-case of the BMI160 sensor.
   * **Hardware:** The example assumes the presence of a BMI160 sensor connected to a supported board.
   * **Documentation:**  A brief section will be added to the BMI160 driver documentation referencing this new example and explaining urob mode configuration.
   * **Other Impacts:** No other impacts are anticipated. 
   ```
   
   **Remember:** A well-written PR description saves reviewers time and increases the chances of your code being merged quickly! 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/bmi160:bmi160 add urob mode example. [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #2691:
URL: https://github.com/apache/nuttx-apps/pull/2691#issuecomment-2408313718

   let's ignore macOS ci temp break.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] examples/bmi160:bmi160 add urob mode example. [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2691:
URL: https://github.com/apache/nuttx-apps/pull/2691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org