You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/08/10 18:12:05 UTC

[kudu-CR] WIP: clock: add a built-in NTP client implementation

David Ribeiro Alves has posted comments on this change.

Change subject: WIP: clock: add a built-in NTP client implementation
......................................................................


Patch Set 5:

(1 comment)

only browsed this briefly. The direction looks good, but would like to have some docs before taking an informed in-depth look

http://gerrit.cloudera.org:8080/#/c/7477/5/src/kudu/clock/builtin_ntp.h
File src/kudu/clock/builtin_ntp.h:

PS5, Line 70: CombineClocks
some docs even on the wip would be helpful.


-- 
To view, visit http://gerrit.cloudera.org:8080/7477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb9eee9f0334236f39617492bd6f01304d1a0255
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes