You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kawadakk (via GitHub)" <gi...@apache.org> on 2023/03/13 09:51:53 UTC

[GitHub] [arrow-datafusion] kawadakk opened a new issue, #5573: `LogicalPlan::replace_params_with_values` should not take `&Vec<_>`

kawadakk opened a new issue, #5573:
URL: https://github.com/apache/arrow-datafusion/issues/5573

   **Describe the bug**
   [`LogicalPlan::replace_params_with_values`](https://docs.rs/datafusion-expr/19.0.0/datafusion_expr/logical_plan/enum.LogicalPlan.html#method.replace_params_with_values) takes `&Vec<ScalarValue>`, forcing the caller to collect inputs in `Vec<ScalarValue>` (instead of an arbitrary continuous container) with no benefits.
   
   https://github.com/apache/arrow-datafusion/blob/aeb593f719508973fa4564a32bc2adc767c3713e/datafusion/expr/src/logical_plan/plan.rs#L630-L636
   
   **To Reproduce**
   N/A
   
   **Expected behavior**
   A common practice, enforced by [the `ptr_arg` Clippy lint](https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg), is to pass such parameters by slice references (`&[ScalarValue]`).
   
   **Additional context**
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #5573: `LogicalPlan::replace_params_with_values` should not take `&Vec<_>`

Posted by "HaoYang670 (via GitHub)" <gi...@apache.org>.

HaoYang670 commented on issue #5573:
URL: https://github.com/apache/arrow-datafusion/issues/5573#issuecomment-1473064067

   Thank you, @kawadakk, for reporting this. I will try to fix it this weekend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #5573: `LogicalPlan::replace_params_with_values` should not take `&Vec<_>`

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb closed issue #5573: `LogicalPlan::replace_params_with_values` should not take `&Vec<_>`
URL: https://github.com/apache/arrow-datafusion/issues/5573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org