You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 15:39:54 UTC

[GitHub] [airflow] ashb commented on pull request #12388: [AIRFLOW-6786] Added Kafka components, 3rd time's the charm

ashb commented on pull request #12388:
URL: https://github.com/apache/airflow/pull/12388#issuecomment-854822852


   > Yup, I'll pick this up and finish it off/get it over the line.
   > 
   > Sorry I forgot about it (AGAIN!)
   
   I've taken a look at this PR, and it's further from being ready to merge than I thought.
   
   - there's no unit tests to speak of (or at all realy)
   - The Sensor takes a host and port, but not connection id parameters
   - The consumer Hook takes host and port but ignores these (it shouldnt' accept them)
   - Commented out code doesn't belong in git.
   
   
   In short: there is more work here than I thought to get this in a state to be merged, so I don't have time right now. Sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org