You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Daniel Becker (Jira)" <ji...@apache.org> on 2023/04/25 15:00:00 UTC
[jira] [Updated] (IMPALA-12098) Remove duplicate implementations in read-write-util.h and bit-stream-utils.h
[ https://issues.apache.org/jira/browse/IMPALA-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Becker updated IMPALA-12098:
-----------------------------------
Description:
Some functions do essentially the same thing in read-write-util.h and bit-stream-utils.h. We could either remove some of them or implement some of them in terms of the other.
Examples:
ReadWriteUtil::PutZLong, ReadWriteUtil::PutZInt - BitWriter::PutZigZagInteger
ReadWriteUtil::ReadZLong, ReadWriteUtil::ReadZInt - BatchedBitReader::GetZigZagInteger
Note that ReadWriteUtil::PutVLong and ReadWriteUtil::PutVInt do NOT correspond to BitWriter::PutUleb128, but ReadWriteUtil::PutZ{Long,Int} do contain logic that does the same thing as BitWriter::PutUleb128 so we could also extract that.
was:
Some functions do essentially the same thing in read-write-util.h and bit-stream-utils.h. We could either remove some of them or implement some of them in terms of the other.
Examples:
ReadWriteUtil::PutZLong, ReadWriteUtil::PutZInt - BitWriter::PutZigZagInteger
ReadWriteUtil::ReadZLong, ReadWriteUtil::ReadZInt - BatchedBitReader::GetZigZagInteger
Not that ReadWriteUtil::PutVLong and ReadWriteUtil::PutVInt do NOT correspond to BitWriter::PutUleb128.
> Remove duplicate implementations in read-write-util.h and bit-stream-utils.h
> ----------------------------------------------------------------------------
>
> Key: IMPALA-12098
> URL: https://issues.apache.org/jira/browse/IMPALA-12098
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Daniel Becker
> Assignee: Daniel Becker
> Priority: Major
>
> Some functions do essentially the same thing in read-write-util.h and bit-stream-utils.h. We could either remove some of them or implement some of them in terms of the other.
> Examples:
> ReadWriteUtil::PutZLong, ReadWriteUtil::PutZInt - BitWriter::PutZigZagInteger
> ReadWriteUtil::ReadZLong, ReadWriteUtil::ReadZInt - BatchedBitReader::GetZigZagInteger
> Note that ReadWriteUtil::PutVLong and ReadWriteUtil::PutVInt do NOT correspond to BitWriter::PutUleb128, but ReadWriteUtil::PutZ{Long,Int} do contain logic that does the same thing as BitWriter::PutUleb128 so we could also extract that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org