You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 10:15:23 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request, #1373: ORC-1343: Disable ENABLE_INDEXES
dongjoon-hyun opened a new pull request, #1373:
URL: https://github.com/apache/orc/pull/1373
### What changes were proposed in this pull request?
This is a partial revert of ORC-1283.
### Why are the changes needed?
ORC reader assumes built-in indexes always so far.
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377025223
cc @deshanxiao and @PengleiShi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377088234
Yes, we should proceed that very carefully, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1373: ORC-1343: Disable ENABLE_INDEXES
URL: https://github.com/apache/orc/pull/1373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377087375
Thank you, @deshanxiao . Merged to branch-1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377087036
LGTM thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377050421
cc @guiyanakuang and @williamhyun , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377092403
> +1 LGTM.
>
> BTW, with `orc.create.index` enabled in the future, I think we should, in any case, set `orc.row.index.stride` to 0 when `orc.create.index=false`.
>
> Because this will ensure that readers of older versions can read files written by newer versions.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1373: ORC-1343: Disable ENABLE_INDEXES
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on PR #1373:
URL: https://github.com/apache/orc/pull/1373#issuecomment-1377087314
+1 LGTM.
BTW, with `orc.create.index` enabled in the future, I think we should, in any case, set `orc.row.index.stride` to 0 when `orc.create.index=false`.
Because this will ensure that readers of older versions can read files written by newer versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org