You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/14 16:37:28 UTC

[GitHub] [beam] lukecwik commented on pull request #12825: [BEAM-9399] Change DataflowWorkerLoggingHandler to report errors to t…

lukecwik commented on pull request #12825:
URL: https://github.com/apache/beam/pull/12825#issuecomment-692173705


   @scwhittle 
   I see how the deadlock occurs but why introduce the synchronized(buffer) if we are swapping out the error manager?
   
   Also, wouldn't we solve the locking problem if we always held the same "flush" lock when interacting with the error manager?
   We could do this by sharing a single lock object across the error manager, print stream, ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org