You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2021/05/05 22:05:37 UTC

[GitHub] [lucenenet] NightOwl888 commented on issue #363: Investigate Failing Test: Lucene.Net.Replicator.Http.HttpReplicatorTest::TestBasic()

NightOwl888 commented on issue #363:
URL: https://github.com/apache/lucenenet/issues/363#issuecomment-833078253


   Unfortunately, even with the `[Repeat]` or [`[FindFirstFailingSeed]`](https://github.com/nunit/nunit/issues/1461#issuecomment-429580661) attributes I was unable to get this to fail on my local (Windows 10) system, but admittedly I gave up rather easily after only a couple of attempts. Perhaps doing a Debug build on Azure DevOps, downloading the `testbinaries` assets, and then doing a local `dotnet test` while [attaching a debugger](https://github.com/dotnet/sdk/issues/4994#issuecomment-431147227) is a way of reproducing it, but that hasn't been attempted yet.
   
   This might have something to do with the fact that we have upgraded `Microsoft.AspNetCore.TestHost` to 2.0.0 when we dropped support for .NET Standard 1.x, or it might just be something we missed because the tests weren't run frequently before the nightly build was set up.
   
   > Off topic:  It isn't clear whether the [`ReplicationClient.ReplicationThread`](https://github.com/apache/lucenenet/blob/Lucene.Net_4_8_0_beta00014/src/Lucene.Net.Replicator/ReplicationClient.cs#L48) is working as was expected, being that in Lucene it was passing `ThreadInterruptedException` from the background thread to the calling thread. Would reverting this to a [`ThreadJob`](https://github.com/NightOwl888/J2N/blob/release/v2.0/src/J2N/Threading/ThreadJob.cs) subclass (going back to a more Java-like design) break anything substantial? `ThreadJob` takes care of propagating the first exception from the background thread to the calling thread. 
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org