You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:04:49 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #27881: Remove is_mapped attribute
uranusjr opened a new pull request, #27881:
URL: https://github.com/apache/airflow/pull/27881
After task group mapping is implemented, the semantic of an operator being "mapped" becomes ambiguous, since it can mean either "the operator is itself mapped" (i.e. a MappedOperator) or "the operator is mapped to multiple task instances" (can be either a MappedOperator, or inside a MappedTaskGroup). This makes the use of the "is_mapped" flag awkward and induces some subtle bugs found during testing.
Therefore, this PR proposes to remove the is_mapped flag, and rely entirely on isinstance checks to more explicitly identify the two kinds of task mapping constructs instead. A couple of bugs are also caught during refactoring.
Note that the is_mapped fields in *serialized formats* (serialized operator, and JSON responses returned by API calls) are not removed, so front end code is not affected. The fields are simply modified to also rely on isinstance checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #27881: Remove is_mapped attribute
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #27881:
URL: https://github.com/apache/airflow/pull/27881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #27881: Remove is_mapped attribute
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #27881:
URL: https://github.com/apache/airflow/pull/27881#issuecomment-1326212482
If there were some bugs do we need to add to the test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #27881: Remove is_mapped attribute
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #27881:
URL: https://github.com/apache/airflow/pull/27881#issuecomment-1326241084
Hmm yeah, we should add test(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org