You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/01 04:58:24 UTC
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request
#2620: [GOBBLIN-756] Add flow catalog that updates when filesystem is
modified
autumnust commented on a change in pull request #2620: [GOBBLIN-756] Add flow catalog that updates when filesystem is modified
URL: https://github.com/apache/incubator-gobblin/pull/2620#discussion_r280003441
##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompiler.java
##########
@@ -186,6 +192,9 @@ public void awaitHealthy() throws InterruptedException {
}
Instrumented.markMeter(flowCompilationSuccessFulMeter);
Instrumented.updateTimer(flowCompilationTimer, System.nanoTime() - startTime, TimeUnit.NANOSECONDS);
+
+ this.rwLock.readLock().unlock();
Review comment:
Shall we put it in `finally` block ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services