You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@answer.apache.org by "culfin (via GitHub)" <gi...@apache.org> on 2026/08/24 15:52:26 UTC
[PR] fix(ui): give the admin area a main landmark [answer]
culfin opened a new pull request, #1589:
URL: https://github.com/apache/answer/pull/1589
Follow-up to #1587, which covered the two layouts that carry the side
navigation. The admin area has a layout of its own and sits directly under
`pages/Layout` in the router, so it was not included there. It covers 28
routes.
Same two changes as in #1587: the wrapper around `Outlet` becomes `main`, the
sidebar container becomes `nav`. Class names untouched, so nothing moves.
### A correction to #1587
That PR names `Users/Settings` and `Legal` as also needing a landmark of their
own. **They do not.** Both are nested inside `SideNavLayout`:
```
pages/Layout
pages/SideNavLayout
pages/Users/Settings ← already inside the main added by #1587
pages/Admin ← this PR
pages/SideNavLayoutWithoutFooter
pages/Layout
pages/SideNavLayout
pages/Legal ← already inside it too
```
Adding a second `main` there would be worse than none, since only one per page
is valid. Sorry for the noise in the other description.
### Still open
Twenty routes hang directly under `pages/Layout` with no layout of their own —
sign-in, registration, the error pages. Giving each one a landmark means either
twenty edits or a small `PlainLayout` wrapper in the router. That is a
different kind of change and belongs in its own PR; I am happy to send it if
you would like it.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org
Re: [PR] fix(ui): give the admin area a main landmark [answer]
Posted by "culfin (via GitHub)" <gi...@apache.org>.
culfin commented on PR #1589:
URL: https://github.com/apache/answer/pull/1589#issuecomment-5399284518
Folded into #1587, which now covers every route rather than a third of them. Nothing is dropped; the commits are on that branch. Closing to keep the queue readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org
Re: [PR] fix(ui): give the admin area a main landmark [answer]
Posted by "culfin (via GitHub)" <gi...@apache.org>.
culfin closed pull request #1589: fix(ui): give the admin area a main landmark
URL: https://github.com/apache/answer/pull/1589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org