You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/11/12 00:22:51 UTC
[jira] [Created] (HBASE-4776) HLog.closed should be checked inside
of updateLock
HLog.closed should be checked inside of updateLock
--------------------------------------------------
Key: HBASE-4776
URL: https://issues.apache.org/jira/browse/HBASE-4776
Project: HBase
Issue Type: Bug
Reporter: Nicolas Spiegelberg
Assignee: Nicolas Spiegelberg
Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4776) HLog.closed should be checked inside
of updateLock
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4776:
---------------------------------------
Status: Patch Available (was: Open)
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149345#comment-13149345 ]
stack commented on HBASE-4776:
------------------------------
So we can commit this? (I'm good w/ commit to 0.92)
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4776) HLog.closed should be checked inside
of updateLock
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4776:
---------------------------------------
Attachment: HBASE-4776.patch
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150129#comment-13150129 ]
Hudson commented on HBASE-4776:
-------------------------------
Integrated in HBase-0.92 #131 (See [https://builds.apache.org/job/HBase-0.92/131/])
HBASE-4776 HLog.closed should be checked inside of updateLock
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4776) HLog.closed should be checked inside
of updateLock
Posted by "Nicolas Spiegelberg (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg reassigned HBASE-4776:
------------------------------------------
Assignee: Prakash Khemani (was: Nicolas Spiegelberg)
Original issue found & patch written by Prakash
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148877#comment-13148877 ]
Ted Yu commented on HBASE-4776:
-------------------------------
The above call is needed because the following is called prior to checking closed flag:
{code}
HLog.Writer nextWriter = this.createWriterInstance(fs, newPath, conf);
{code}
This change would activate preLogRoll() and postLogRoll() for listeners. Previously listeners wouldn't have been notified if closed is true upon entering rollWriter().
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148831#comment-13148831 ]
Nicolas Spiegelberg commented on HBASE-4776:
--------------------------------------------
Part of 89-fb to trunk port. See r1181573
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148848#comment-13148848 ]
Hadoop QA commented on HBASE-4776:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503446/HBASE-4776.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/235//console
This message is automatically generated.
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4776) HLog.closed should be checked inside
of updateLock
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4776:
-------------------------
Fix Version/s: 0.92.0
Committed to 0.92 too.
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4776) HLog.closed should be checked
inside of updateLock
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148866#comment-13148866 ]
Lars Hofhansl commented on HBASE-4776:
--------------------------------------
Old code didn't do this before:
{code}
+ nextWriter.close(); // creates empty log file
{code}
Is that intentional?
Otherwise +1
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4776) HLog.closed should be checked inside
of updateLock
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4776:
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Status: Resolved (was: Patch Available)
> HLog.closed should be checked inside of updateLock
> --------------------------------------------------
>
> Key: HBASE-4776
> URL: https://issues.apache.org/jira/browse/HBASE-4776
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Prakash Khemani
> Fix For: 0.94.0
>
> Attachments: HBASE-4776.patch
>
>
> Concurrency issue: HLog.closed is set inside the updateLock but not checked inside the lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira