[cordova-cli] branch master updated: CB-12853 re-check version before notifying. Actually a update-notifier issue.

[pu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

purplecabbage pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new 0a5b07a  CB-12853 re-check version before notifying. Actually a update-notifier issue.
0a5b07a is described below

commit 0a5b07a7bf5739b93182a80de17de82b333c8946
Author: Jesse MacFadyen <pu...@gmail.com>
AuthorDate: Thu Dec 7 23:53:30 2017 -0800

    CB-12853 re-check version before notifying. Actually a update-notifier issue.
---
 src/cli.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/cli.js b/src/cli.js
index c029578..4adb009 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -77,11 +77,13 @@ var shortHands = {
 function checkForUpdates () {
     try {
         // Checks for available update and returns an instance
-        var notifier = updateNotifier({
-            pkg: pkg
-        });
-        // Notify using the built-in convenience method
-        notifier.notify();
+        var notifier = updateNotifier({pkg:pkg});
+
+        if(notifier.update &&
+           notifier.update.latest !== pkg.version) {
+            // Notify using the built-in convenience method
+            notifier.notify();
+        }
     } catch (e) {
         // https://issues.apache.org/jira/browse/CB-10062
         if (e && e.message && /EACCES/.test(e.message)) {

-- 
To stop receiving notification emails like this one, please contact
['"commits@cordova.apache.org" <co...@cordova.apache.org>'].

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org