[jira] Updated: (DIRSHARED-64) IStates and inherited interfaces/implementing classes shpuld be enums

["Felix Knecht (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRSHARED-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated DIRSHARED-64:
----------------------------------

    Attachment: IState2Enum.patch

"I tried to transform State to become an Enum, but it's not that easy...
We use the value as an index in an array in grammars, and I failed to use an enum there. May be it worth another attempt.
I'm also afraid that it must be fixed globally. "

This unsettled me a bit.

That's what I'd do for the IStates->enum. Is this what the issues is about? At least Shared tests are passing. ApacheDS are failing in the ConfigPartitionReaderTest (which hardly is an impact of the patch).

If ok I'll commit it and start with the States Pierre-Arnaud pointed in an equal way.

> IStates and inherited interfaces/implementing classes shpuld be enums
> ---------------------------------------------------------------------
>
>                 Key: DIRSHARED-64
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-64
>             Project: Directory Shared
>          Issue Type: Improvement
>    Affects Versions: 0.9.19
>            Reporter: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: IState2Enum.patch
>
>
> We should transform this interface to be an Enum

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.