You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/23 05:40:08 UTC
[GitHub] [druid] maytasm opened a new pull request, #12697: Add some debug tips for debugging peons
maytasm opened a new pull request, #12697:
URL: https://github.com/apache/druid/pull/12697
Add some debug tips for debugging peons
### Description
- Add some debug tips for debugging peons
- Enable (open debug ports) for peons on Integration tests Druid cluster by default
-
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #12697: Add some debug tips for debugging peons
Posted by GitBox <gi...@apache.org>.
kfaraz commented on code in PR #12697:
URL: https://github.com/apache/druid/pull/12697#discussion_r905311840
##########
dev/intellij-setup.md:
##########
@@ -69,6 +69,14 @@ Before running or debugging the apps, you should do a `mvn clean install -Pdist
You may also add `-Ddruid.console.skip=true` to the command if you're focusing on backend servers instead of frontend project. This option saves great building time.
+## Debugging Running Druid from Intellij
Review Comment:
Nit: The words "debugging" and "running" seem a little confusing in conjunction.
```suggestion
## Debug a running Druid cluster using Intellij
```
or something to that effect.
##########
dev/intellij-setup.md:
##########
@@ -69,6 +69,14 @@ Before running or debugging the apps, you should do a `mvn clean install -Pdist
You may also add `-Ddruid.console.skip=true` to the command if you're focusing on backend servers instead of frontend project. This option saves great building time.
+## Debugging Running Druid from Intellij
+Intellij IDEA debugger can attach to a local or remote Java process (Druid process).
+First, you must enable debugging in the application.
Review Comment:
Would it be better to write these steps in a list format?
Something like:
```suggestion
Follow these steps to debug a Druid process using the IntelliJ IDEA debugger.
1. Enable debugging in the Druid process
a. For Druid services (Overlord, Coordinator, etc.) ...
b. For peons (...
2. Find the port assigned to the Druid process.
a. For Druid services, you can find it in ...
b. For peons, you can find the assigned ephemeral port ... task log
3. Create a remote configuration in the Run/Debug configurations dialog ...
4. Start (debug) the above remote configuration
```
##########
integration-tests/README.md:
##########
@@ -212,6 +212,7 @@ For your convenience, Druid processes running inside Docker have been debugging
| Historical | 5007 |
| Middlemanager | 5008 |
| Overlord | 5009 |
+| Peons (Workers on Middle Manager) | Ephemeral port assigned by debugger (check task log for port assigned to each task)
Review Comment:
Nit: to correspond to previous lines:
```suggestion
| Peons (Workers on Middlemanager) | Ephemeral port assigned by debugger (check task log for port assigned to each task) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a diff in pull request #12697: Add some debug tips for debugging peons
Posted by GitBox <gi...@apache.org>.
maytasm commented on code in PR #12697:
URL: https://github.com/apache/druid/pull/12697#discussion_r917136172
##########
dev/intellij-setup.md:
##########
@@ -69,6 +69,14 @@ Before running or debugging the apps, you should do a `mvn clean install -Pdist
You may also add `-Ddruid.console.skip=true` to the command if you're focusing on backend servers instead of frontend project. This option saves great building time.
+## Debugging Running Druid from Intellij
+Intellij IDEA debugger can attach to a local or remote Java process (Druid process).
+First, you must enable debugging in the application.
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a diff in pull request #12697: Add some debug tips for debugging peons
Posted by GitBox <gi...@apache.org>.
maytasm commented on code in PR #12697:
URL: https://github.com/apache/druid/pull/12697#discussion_r917126960
##########
dev/intellij-setup.md:
##########
@@ -69,6 +69,14 @@ Before running or debugging the apps, you should do a `mvn clean install -Pdist
You may also add `-Ddruid.console.skip=true` to the command if you're focusing on backend servers instead of frontend project. This option saves great building time.
+## Debugging Running Druid from Intellij
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm merged pull request #12697: Add some debug tips for debugging peons
Posted by GitBox <gi...@apache.org>.
maytasm merged PR #12697:
URL: https://github.com/apache/druid/pull/12697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a diff in pull request #12697: Add some debug tips for debugging peons
Posted by GitBox <gi...@apache.org>.
maytasm commented on code in PR #12697:
URL: https://github.com/apache/druid/pull/12697#discussion_r917127367
##########
integration-tests/README.md:
##########
@@ -212,6 +212,7 @@ For your convenience, Druid processes running inside Docker have been debugging
| Historical | 5007 |
| Middlemanager | 5008 |
| Overlord | 5009 |
+| Peons (Workers on Middle Manager) | Ephemeral port assigned by debugger (check task log for port assigned to each task)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org