You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Bertil Chapuis (JIRA)" <ji...@apache.org> on 2011/01/11 08:37:45 UTC

[jira] Updated: (DROIDS-56) Change the TaskQueue interface to java.util.Queue

     [ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertil Chapuis updated DROIDS-56:
---------------------------------

    Attachment: droids-56-v2.diff

The tests are now passing. I made some deep changes in the TaskMasters to handle java.util.Queue. One of them is the usage of the ThreadPoolExecutor's afterExecute method. I use it to resubmit tasks to the Executor. It could be nice to have a review of this part of the code.

> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
>                 Key: DROIDS-56
>                 URL: https://issues.apache.org/jira/browse/DROIDS-56
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Mingfai Ma
>         Attachments: droids-56-v2.diff, droids-56.diff, Queue.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue. 
> 2. either remove the TaskQueue or make it extends java.util.Queue
>  - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.