[GitHub] rob05c opened a new pull request #3007: Change Monitor stat history to sync.Map

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #3007: Change Monitor stat history to sync.Map
URL: https://github.com/apache/trafficcontrol/pull/3007
 
 
   #### What does this PR do?
   
   Change Monitor stat history to sync.Map
   
       This significantly improves performance. In my testing, for a large
       CDN, processing Stat results can take ~5 seconds, where ~1s of that
       was copying and setting the mutexed stat history variable. This
       essentially eliminates that 1s or 1/5 of stat processing time, for
       every stat process. This significantly reduces CPU, and/or makes
       the monitor able to poll stats in significantly less time.
       
       Also changes the stat history array to not reallocate memory,
       but move the data when prepending a new result. Which is also
       significantly faster, in my testing.
   
   #### Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [x] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   #### What is the best way to verify this PR?
   
   Run Monitor, verify health and stats are polled correctly. This PR does not change the interface; it's an internal performance improvement.
   
   #### Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services