[GitHub] [inlong] luchunliang commented on a diff in pull request #5173: [INLONG-5167][Manager][Agent][Dataproxy][SDK] Manager open API authentication support

[GitBox <gi...@apache.org>]

luchunliang commented on code in PR #5173:
URL: https://github.com/apache/inlong/pull/5173#discussion_r927277632


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/UserServiceImpl.java:
##########
@@ -121,7 +121,7 @@ public boolean create(UserInfo userInfo) {
             Map<String, String> keyPairs = RSAUtils.generateRSAKeyPairs();
             String publicKey = keyPairs.get(RSAUtils.PUBLIC_KEY);
             String privateKey = keyPairs.get(RSAUtils.PRIVATE_KEY);
-            String secretKey = RandomStringUtils.randomAlphanumeric(8);
+            String secretKey = RandomStringUtils.randomAlphanumeric(16);

Review Comment:
   16 is magic number?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org