You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/09/29 14:18:08 UTC

[jira] [Commented] (LANG-804) Redundant check for zero in HashCodeBuilder ctor

    [ https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466196#comment-13466196 ] 

Sebb commented on LANG-804:
---------------------------

More to the point, perhaps the ctor should check for positive numbers.

Does it make sense for the user to provide negative numbers?
                
> Redundant check for zero in HashCodeBuilder ctor
> ------------------------------------------------
>
>                 Key: LANG-804
>                 URL: https://issues.apache.org/jira/browse/LANG-804
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>            Reporter: Sebb
>            Priority: Minor
>
> The HashCodeBuilder(int, int) ctor checks both parameters for zero, as well as checking for an odd number.
> Zero is never odd, so the zero check could be eliminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira