You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/29 15:04:06 UTC

[GitHub] [solr] bruno-roustant opened a new pull request, #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

bruno-roustant opened a new pull request, #1048:
URL: https://github.com/apache/solr/pull/1048

   - Introduce the optional split.setPreferredLeaders prop on CollectionAdminRequest#SplitShard.
   - Make SplitShardCommand support it and set the preferredLeader property on other replicas of each created sub-shard. Distributing the preferred leaders evenly.
   -  Introduce combined operations in CollectionsHandler, so that a CollectionOperation (e.g. SPLITSHARD_OP) can look at the request and (e.g. if split.setPreferredLeaders is set) create a sequence of operations to execute (e.g. split, wait for completion, rebalance leaders).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
dsmiley commented on code in PR #1048:
URL: https://github.com/apache/solr/pull/1048#discussion_r1040413560


##########
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##########
@@ -1205,7 +1205,6 @@ private void doDefensiveChecks(DistribPhase phase) {
     }
 
     if ((isLeader && !localIsLeader) || (isSubShardLeader && !localIsLeader)) {
-      log.error("ClusterState says we are the leader, but locally we don't think so");

Review Comment:
   commenting this seems to be out of scope



##########
solr/CHANGES.txt:
##########
@@ -41,6 +41,8 @@ New Features
 
 * SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI (Jeanie Lam via Eric Pugh)
 
+* SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command. (Bruno Roustant)

Review Comment:
   I don't see Solr Ref Guide changes



##########
solr/CHANGES.txt:
##########
@@ -41,6 +41,8 @@ New Features
 
 * SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI (Jeanie Lam via Eric Pugh)
 
+* SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command. (Bruno Roustant)

Review Comment:
   People debate this sort of thing but I think of this as an improvement to a feature and not a new feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bruno-roustant commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
bruno-roustant commented on PR #1048:
URL: https://github.com/apache/solr/pull/1048#issuecomment-1354539553

   Thanks for the review!
   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bruno-roustant commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
bruno-roustant commented on code in PR #1048:
URL: https://github.com/apache/solr/pull/1048#discussion_r983671635


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState, ZkNodeProps message, NamedList<O
         } else {
           ccc.offerStateUpdate(Utils.toJSON(m));
         }
+

Review Comment:
   This fixes a race condition between setting the shards in RECOVERY state and adding more replicas. Thanks @andyvuong for this fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bruno-roustant commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
bruno-roustant commented on PR #1048:
URL: https://github.com/apache/solr/pull/1048#issuecomment-1337147180

   @dsmiley I refreshed to be up to date, and I added the solr.autoPreferredLeader property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
dsmiley commented on code in PR #1048:
URL: https://github.com/apache/solr/pull/1048#discussion_r983869369


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState, ZkNodeProps message, NamedList<O
         } else {
           ccc.offerStateUpdate(Utils.toJSON(m));
         }
+

Review Comment:
   I feel that race deserves its own issue/pr.  @andyvuong if you don't want to create it, we can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1048:
URL: https://github.com/apache/solr/pull/1048#issuecomment-1262489752

   :warning: **313 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GE4WDEEV964PWHFNF9FGZ721?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bruno-roustant closed pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
bruno-roustant closed pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.
URL: https://github.com/apache/solr/pull/1048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] bruno-roustant commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

Posted by GitBox <gi...@apache.org>.
bruno-roustant commented on PR #1048:
URL: https://github.com/apache/solr/pull/1048#issuecomment-1283710529

   @dsmiley I rebased with the recent works on these classes. Ready for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org