You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/09/29 13:55:27 UTC
[GitHub] [submarine] kobe860219 opened a new pull request #421: SUBMARINE-647. Change Workbench user name
kobe860219 opened a new pull request #421:
URL: https://github.com/apache/submarine/pull/421
### What is this PR for?
The user name at the top-right corner is liuxun, should change to admin
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-647
### How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/731279516
### Screenshots (if appropriate)
<img width="1440" alt="ζͺε 2020-09-29 δΈε9 54 31" src="https://user-images.githubusercontent.com/48027290/94567781-68b96180-029e-11eb-9438-55539fd2d41c.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] xunliu commented on a change in pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
xunliu commented on a change in pull request #421:
URL: https://github.com/apache/submarine/pull/421#discussion_r497394628
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.component.ts
##########
@@ -130,7 +130,7 @@ export class WorkbenchComponent implements OnInit {
if (this.authService.isLoggedIn) {
this.userInfo$ = this.userService.fetchUserInfo().pipe(
tap((userInfo) => {
- this.nzNotificationService.success('Welcome', `Welcome back, ${userInfo.name}`);
+ this.nzNotificationService.success('Welcome', `Welcome to submarine workbench!`);
Review comment:
`userInfo.name` This username is queried from the database and cannot be written as a fixed value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] aeioulisa commented on a change in pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
aeioulisa commented on a change in pull request #421:
URL: https://github.com/apache/submarine/pull/421#discussion_r498071121
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.component.html
##########
@@ -71,7 +71,7 @@ <h1>Submarine</h1>
class="operation-user-info"
>
<nz-avatar nzIcon="user" nzSize="small"></nz-avatar>
- {{ userInfo.name }}
+ {{ userInfo.name }}
Review comment:
```suggestion
{{ userInfo.name }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] aeioulisa removed a comment on pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
aeioulisa removed a comment on pull request #421:
URL: https://github.com/apache/submarine/pull/421#issuecomment-701338735
https://github.com/apache/submarine/blob/cdb2e7f8b17c1badbcd0601d8200b947f9a37a97/submarine-server/server-core/src/main/java/org/apache/submarine/server/workbench/rest/SysUserRestApi.java#L228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] xunliu commented on a change in pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
xunliu commented on a change in pull request #421:
URL: https://github.com/apache/submarine/pull/421#discussion_r497393805
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.component.html
##########
@@ -71,7 +71,7 @@ <h1>Submarine</h1>
class="operation-user-info"
>
<nz-avatar nzIcon="user" nzSize="small"></nz-avatar>
- {{ userInfo.name }}
+ admin
Review comment:
No! `userInfo.name` This username is queried from the database and cannot be written as a fixed value.
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/workbench.component.html
##########
@@ -71,7 +71,7 @@ <h1>Submarine</h1>
class="operation-user-info"
>
<nz-avatar nzIcon="user" nzSize="small"></nz-avatar>
- {{ userInfo.name }}
+ admin
Review comment:
No! `userInfo.name` This username is queried from the database and cannot be written as a fixed value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #421:
URL: https://github.com/apache/submarine/pull/421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] aeioulisa commented on pull request #421: SUBMARINE-647. Change Workbench user name
Posted by GitBox <gi...@apache.org>.
aeioulisa commented on pull request #421:
URL: https://github.com/apache/submarine/pull/421#issuecomment-701338735
https://github.com/apache/submarine/blob/cdb2e7f8b17c1badbcd0601d8200b947f9a37a97/submarine-server/server-core/src/main/java/org/apache/submarine/server/workbench/rest/SysUserRestApi.java#L228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org