You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/10 21:18:30 UTC
[GitHub] [flink] pnowojski opened a new pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
pnowojski opened a new pull request #16774:
URL: https://github.com/apache/flink/pull/16774
TODO
## Verifying this change
Add a various unit tests for missing test coverage
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / no ****/ don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* afbaed01f0574836eea2ef7cade1b4190e34c0cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858)
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
* 5e6e5bfa02a1099a1ac3540ad87247345f1a554b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885)
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896324292
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 29f6f8c37ad761b83406b1256b07e8daad3c7cc2 (Tue Aug 10 21:21:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* afbaed01f0574836eea2ef7cade1b4190e34c0cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858)
* 323619080781e229f661b10f201ccbe370cb0a04 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
* 5e6e5bfa02a1099a1ac3540ad87247345f1a554b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22170",
"triggerID" : "898859591",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 09bc398ff584c719e663b73aa5971eb422b147a0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r687639592
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOperatorChain.java
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.tasks;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriter;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriterDelegate;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.operators.coordination.OperatorEvent;
+import org.apache.flink.runtime.plugable.SerializationDelegate;
+import org.apache.flink.runtime.state.CheckpointStreamFactory;
+import org.apache.flink.runtime.state.TaskStateManager;
+import org.apache.flink.streaming.api.graph.StreamConfig;
+import org.apache.flink.streaming.api.graph.StreamEdge;
+import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
+import org.apache.flink.streaming.api.operators.OperatorSnapshotFutures;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.api.operators.StreamOperator;
+import org.apache.flink.streaming.api.operators.StreamOperatorFactoryUtil;
+import org.apache.flink.streaming.api.operators.StreamTaskStateInitializer;
+import org.apache.flink.streaming.runtime.io.RecordWriterOutput;
+import org.apache.flink.streaming.runtime.io.StreamTaskSourceInput;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.mailbox.MailboxExecutorFactory;
+import org.apache.flink.util.OutputTag;
+import org.apache.flink.util.SerializedValue;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Supplier;
+
+/**
+ * The {@link OperatorChain} that is used for restoring tasks that are {@link
+ * TaskStateManager#isFinishedOnRestore()}.
+ */
+@Internal
+public class FinishedOperatorChain<OUT, OP extends StreamOperator<OUT>>
+ extends OperatorChain<OUT, OP> {
+
+ public FinishedOperatorChain(
+ StreamTask<OUT, OP> containingTask,
+ RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>> recordWriterDelegate) {
+ super(containingTask, recordWriterDelegate);
+ }
+
+ @Override
+ public boolean isFinishedOnRestore() {
+ return true;
+ }
+
+ @Override
+ public void dispatchOperatorEvent(OperatorID operator, SerializedValue<OperatorEvent> event) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void prepareSnapshotPreBarrier(long checkpointId) {}
+
+ @Override
+ public void endInput(int inputId) throws Exception {}
+
+ @Override
+ public void initializeStateAndOpenOperators(
+ StreamTaskStateInitializer streamTaskStateInitializer) {}
+
+ @Override
+ public void finishOperators(StreamTaskActionExecutor actionExecutor) throws Exception {}
+
+ @Override
+ public void close() throws IOException {
Review comment:
This method might not need override
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -609,16 +586,13 @@ private boolean takeSnapshotSync(
Supplier<Boolean> isRunning)
throws Exception {
- for (final StreamOperatorWrapper<?, ?> operatorWrapper :
- operatorChain.getAllOperators(true)) {
- if (!enableCheckpointAfterTasksFinished && operatorWrapper.isClosed()) {
- env.declineCheckpoint(
- checkpointMetaData.getCheckpointId(),
- new CheckpointException(
- "Task Name" + taskName,
- CheckpointFailureReason.CHECKPOINT_DECLINED_TASK_CLOSING));
- return false;
- }
+ if (!enableCheckpointAfterTasksFinished && operatorChain.isClosed()) {
Review comment:
Although it is not introduced in this PR, we could always decline the checkpoint no matter what the value of `enableCheckpointAfterTasksFinished` is. Since now we change the meaning of `close` to dispose the operator, it is called at the last step of the task, at that time the mailbox has been closed and there should be no new checkpoints.
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskChainedSourcesCheckpointingTest.java
##########
@@ -490,12 +494,8 @@ public void notifyEndOfData() throws IOException {
.finishForSingletonOperatorChain(StringSerializer.INSTANCE)
.build()) {
- testHarness.processElement(Watermark.MAX_WATERMARK, 0, 0);
Review comment:
We may keep emitting the MAX_WATERMARK and check the MAX_WATERMARK is passed ?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOperatorChain.java
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.tasks;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriter;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriterDelegate;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.operators.coordination.OperatorEvent;
+import org.apache.flink.runtime.plugable.SerializationDelegate;
+import org.apache.flink.runtime.state.CheckpointStreamFactory;
+import org.apache.flink.runtime.state.TaskStateManager;
+import org.apache.flink.streaming.api.graph.StreamConfig;
+import org.apache.flink.streaming.api.graph.StreamEdge;
+import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
+import org.apache.flink.streaming.api.operators.OperatorSnapshotFutures;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.api.operators.StreamOperator;
+import org.apache.flink.streaming.api.operators.StreamOperatorFactoryUtil;
+import org.apache.flink.streaming.api.operators.StreamTaskStateInitializer;
+import org.apache.flink.streaming.runtime.io.RecordWriterOutput;
+import org.apache.flink.streaming.runtime.io.StreamTaskSourceInput;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.mailbox.MailboxExecutorFactory;
+import org.apache.flink.util.OutputTag;
+import org.apache.flink.util.SerializedValue;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Supplier;
+
+/**
+ * The {@link OperatorChain} that is used for restoring tasks that are {@link
+ * TaskStateManager#isFinishedOnRestore()}.
+ */
+@Internal
+public class FinishedOperatorChain<OUT, OP extends StreamOperator<OUT>>
+ extends OperatorChain<OUT, OP> {
+
+ public FinishedOperatorChain(
+ StreamTask<OUT, OP> containingTask,
+ RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>> recordWriterDelegate) {
+ super(containingTask, recordWriterDelegate);
+ }
+
+ @Override
+ public boolean isFinishedOnRestore() {
+ return true;
+ }
+
+ @Override
+ public void dispatchOperatorEvent(OperatorID operator, SerializedValue<OperatorEvent> event) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void prepareSnapshotPreBarrier(long checkpointId) {}
+
+ @Override
+ public void endInput(int inputId) throws Exception {}
+
+ @Override
+ public void initializeStateAndOpenOperators(
+ StreamTaskStateInitializer streamTaskStateInitializer) {}
+
+ @Override
+ public void finishOperators(StreamTaskActionExecutor actionExecutor) throws Exception {}
+
+ @Override
+ public void close() throws IOException {
+ super.close();
+ }
+
+ // ------------------------------------------------------------------------
Review comment:
It seems the following private methods are not used for `FinishedOperatorChain` ?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessorFactory.java
##########
@@ -289,8 +290,12 @@ public StreamTaskSourceOutput(
}
@Override
- public void emitStreamStatus(StreamStatus streamStatus) throws Exception {
+ public void emitStreamStatus(StreamStatus streamStatus) {
chainedOutput.emitStreamStatus(streamStatus);
}
}
+
+ private interface FinishedOnRestoreSourceWatermarkBypass {
Review comment:
This interface is not used?
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskFinalCheckpointsTest.java
##########
@@ -712,18 +714,24 @@ public void testOperatorSkipLifeCycleIfFinishedOnRestore() throws Exception {
try (StreamTaskMailboxTestHarness<String> harness =
new StreamTaskMailboxTestHarnessBuilder<>(
OneInputStreamTask::new, BasicTypeInfo.STRING_TYPE_INFO)
+ .setCollectNetworkEvents()
.addInput(BasicTypeInfo.STRING_TYPE_INFO, 3)
+ .setCollectNetworkEvents()
Review comment:
The setting is repeated.
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskChainedSourcesCheckpointingTest.java
##########
@@ -507,9 +507,6 @@ public void notifyEndOfData() throws IOException {
sourceReader.getLifeCycleMonitor().assertCallTimes(0, LifeCyclePhase.values());
} else if (wrapper.getStreamOperator()
Review comment:
Remove the empty branch ?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -161,7 +164,11 @@ public OperatorChain(
Map<StreamEdge, RecordWriterOutput<?>> streamOutputMap =
new HashMap<>(outEdgesInOrder.size());
this.streamOutputs = new RecordWriterOutput<?>[outEdgesInOrder.size()];
- this.finishedOnRestore = finishedOnRestore;
+ this.finishedOnRestoreInput =
+ this.isFinishedOnRestore()
Review comment:
Perhaps we could make `getFinishedOnRestoreInputOrDefault` an abstract method to avoid after we have the separate subclasses we still do the judge of if it is `FinishedOnRestore`, but in consider there are might some implementation complexity I would not strongly argue for that for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
* 09bc398ff584c719e663b73aa5971eb422b147a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r688457193
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOperatorChain.java
##########
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.tasks;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriterDelegate;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.operators.coordination.OperatorEvent;
+import org.apache.flink.runtime.plugable.SerializationDelegate;
+import org.apache.flink.runtime.state.CheckpointStreamFactory;
+import org.apache.flink.runtime.state.TaskStateManager;
+import org.apache.flink.streaming.api.operators.OperatorSnapshotFutures;
+import org.apache.flink.streaming.api.operators.StreamOperator;
+import org.apache.flink.streaming.api.operators.StreamTaskStateInitializer;
+import org.apache.flink.streaming.runtime.io.StreamTaskSourceInput;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.util.SerializedValue;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+/**
+ * The {@link OperatorChain} that is used for restoring tasks that are {@link
+ * TaskStateManager#isFinishedOnRestore()}.
+ */
+@Internal
+public class FinishedOperatorChain<OUT, OP extends StreamOperator<OUT>>
+ extends OperatorChain<OUT, OP> {
+
+ public FinishedOperatorChain(
+ StreamTask<OUT, OP> containingTask,
+ RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>> recordWriterDelegate) {
+ super(containingTask, recordWriterDelegate);
+ }
+
+ @Override
+ public boolean isFinishedOnRestore() {
+ return true;
+ }
+
+ @Override
+ public void dispatchOperatorEvent(OperatorID operator, SerializedValue<OperatorEvent> event) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void prepareSnapshotPreBarrier(long checkpointId) {}
+
+ @Override
+ public void endInput(int inputId) throws Exception {}
+
+ @Override
+ public void initializeStateAndOpenOperators(
+ StreamTaskStateInitializer streamTaskStateInitializer) {}
+
+ @Override
+ public void finishOperators(StreamTaskActionExecutor actionExecutor) throws Exception {}
+
+ @Override
+ public void notifyCheckpointComplete(long checkpointId) throws Exception {}
+
+ @Override
+ public void notifyCheckpointAborted(long checkpointId) throws Exception {}
+
+ @Override
+ public boolean isClosed() {
+ return isClosed;
+ }
+
+ @Override
+ public void snapshotState(
+ Map<OperatorID, OperatorSnapshotFutures> operatorSnapshotsInProgress,
+ CheckpointMetaData checkpointMetaData,
+ CheckpointOptions checkpointOptions,
+ Supplier<Boolean> isRunning,
+ ChannelStateWriter.ChannelStateWriteResult channelStateWriteResult,
+ CheckpointStreamFactory storage)
+ throws Exception {}
+
+ /** Wrapper class to access the chained sources and their's outputs. */
+ public static class ChainedSource {
Review comment:
We should be able to also remove this class, it is defined in `OperatorChain`~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 09bc398ff584c719e663b73aa5971eb422b147a0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
* 09bc398ff584c719e663b73aa5971eb422b147a0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 2b311e83b8014e601255134085375acd798eb08c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22170",
"triggerID" : "898859591",
"triggerType" : "MANUAL"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "898859591",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 09bc398ff584c719e663b73aa5971eb422b147a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22170) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* afbaed01f0574836eea2ef7cade1b4190e34c0cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858)
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
* 5e6e5bfa02a1099a1ac3540ad87247345f1a554b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
* 5e6e5bfa02a1099a1ac3540ad87247345f1a554b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885)
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r688299759
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/FinishedOperatorChain.java
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.tasks;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter;
+import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriter;
+import org.apache.flink.runtime.io.network.api.writer.RecordWriterDelegate;
+import org.apache.flink.runtime.jobgraph.OperatorID;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.operators.coordination.OperatorEvent;
+import org.apache.flink.runtime.plugable.SerializationDelegate;
+import org.apache.flink.runtime.state.CheckpointStreamFactory;
+import org.apache.flink.runtime.state.TaskStateManager;
+import org.apache.flink.streaming.api.graph.StreamConfig;
+import org.apache.flink.streaming.api.graph.StreamEdge;
+import org.apache.flink.streaming.api.operators.OneInputStreamOperator;
+import org.apache.flink.streaming.api.operators.OperatorSnapshotFutures;
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.api.operators.StreamOperator;
+import org.apache.flink.streaming.api.operators.StreamOperatorFactoryUtil;
+import org.apache.flink.streaming.api.operators.StreamTaskStateInitializer;
+import org.apache.flink.streaming.runtime.io.RecordWriterOutput;
+import org.apache.flink.streaming.runtime.io.StreamTaskSourceInput;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.mailbox.MailboxExecutorFactory;
+import org.apache.flink.util.OutputTag;
+import org.apache.flink.util.SerializedValue;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.function.Supplier;
+
+/**
+ * The {@link OperatorChain} that is used for restoring tasks that are {@link
+ * TaskStateManager#isFinishedOnRestore()}.
+ */
+@Internal
+public class FinishedOperatorChain<OUT, OP extends StreamOperator<OUT>>
+ extends OperatorChain<OUT, OP> {
+
+ public FinishedOperatorChain(
+ StreamTask<OUT, OP> containingTask,
+ RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>> recordWriterDelegate) {
+ super(containingTask, recordWriterDelegate);
+ }
+
+ @Override
+ public boolean isFinishedOnRestore() {
+ return true;
+ }
+
+ @Override
+ public void dispatchOperatorEvent(OperatorID operator, SerializedValue<OperatorEvent> event) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void prepareSnapshotPreBarrier(long checkpointId) {}
+
+ @Override
+ public void endInput(int inputId) throws Exception {}
+
+ @Override
+ public void initializeStateAndOpenOperators(
+ StreamTaskStateInitializer streamTaskStateInitializer) {}
+
+ @Override
+ public void finishOperators(StreamTaskActionExecutor actionExecutor) throws Exception {}
+
+ @Override
+ public void close() throws IOException {
+ super.close();
+ }
+
+ // ------------------------------------------------------------------------
Review comment:
Ops 😳 good catch :)
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -161,7 +164,11 @@ public OperatorChain(
Map<StreamEdge, RecordWriterOutput<?>> streamOutputMap =
new HashMap<>(outEdgesInOrder.size());
this.streamOutputs = new RecordWriterOutput<?>[outEdgesInOrder.size()];
- this.finishedOnRestore = finishedOnRestore;
+ this.finishedOnRestoreInput =
+ this.isFinishedOnRestore()
Review comment:
I think that would require a more extensive refactor and extracting the logic of creating operators/outputs from `OperatorChain` to some builder class.
The problem is that currently constructor of `OperatorChain()` needs to call `getFinishedOnRestoreInputOrDefault()`. So the field `finishedOnRestoreInput` can not be initialised in the `FinishedOperatorChain`, as it would be too late. So we are stuck with:
```
protected final @Nullable FinishedOnRestoreInput finishedOnRestoreInput;
(...)
this.finishedOnRestoreInput =
this.isFinishedOnRestore()
? new FinishedOnRestoreInput(
streamOutputs, configuration.getInputs(userCodeClassloader).length)
: null;
```
being defined and initialised in the `OperatorChain`. With that in mind, I think it would be actually a slightly less readable code if we had the getter to that `@Nullable` field in the `FinishedOperatorChain` and `RegularOperatorChain`.
As I wrote in the beginning, probably the right way to go would be to construct all outputs/operators in a builder class, and only inject them to the `OperatorChain`. That way field `finishedOnRestoreInput` could be defined in the `FinishedOperatorChain` only. But I would prefer to leave it for a future improvement.
Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* afbaed01f0574836eea2ef7cade1b4190e34c0cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-898859591
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 5e6e5bfa02a1099a1ac3540ad87247345f1a554b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885)
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #16774:
URL: https://github.com/apache/flink/pull/16774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 323619080781e229f661b10f201ccbe370cb0a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* afbaed01f0574836eea2ef7cade1b4190e34c0cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
}, {
"hash" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107",
"triggerID" : "6c8887ec8c0b29ece4c7a8a29316f9592f329cc6",
"triggerType" : "PUSH"
}, {
"hash" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139",
"triggerID" : "09bc398ff584c719e663b73aa5971eb422b147a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* 6c8887ec8c0b29ece4c7a8a29316f9592f329cc6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22107)
* 09bc398ff584c719e663b73aa5971eb422b147a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22139)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
}, {
"hash" : "2b311e83b8014e601255134085375acd798eb08c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083",
"triggerID" : "2b311e83b8014e601255134085375acd798eb08c",
"triggerType" : "PUSH"
}, {
"hash" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090",
"triggerID" : "20f621dc98920a2312b2f65fb81c09446bb07b2e",
"triggerType" : "PUSH"
}, {
"hash" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101",
"triggerID" : "86a1074b9ac2dadba68e6d9aa83fca4814a5486a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
* 2b311e83b8014e601255134085375acd798eb08c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22083)
* 20f621dc98920a2312b2f65fb81c09446bb07b2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22090)
* 86a1074b9ac2dadba68e6d9aa83fca4814a5486a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22101)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r688437386
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -609,16 +586,13 @@ private boolean takeSnapshotSync(
Supplier<Boolean> isRunning)
throws Exception {
- for (final StreamOperatorWrapper<?, ?> operatorWrapper :
- operatorChain.getAllOperators(true)) {
- if (!enableCheckpointAfterTasksFinished && operatorWrapper.isClosed()) {
- env.declineCheckpoint(
- checkpointMetaData.getCheckpointId(),
- new CheckpointException(
- "Task Name" + taskName,
- CheckpointFailureReason.CHECKPOINT_DECLINED_TASK_CLOSING));
- return false;
- }
+ if (!enableCheckpointAfterTasksFinished && operatorChain.isClosed()) {
Review comment:
I've added a separate hotfix commit to change this into `checkState(!operatorChain.isClosed())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r688465837
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -161,7 +164,11 @@ public OperatorChain(
Map<StreamEdge, RecordWriterOutput<?>> streamOutputMap =
new HashMap<>(outEdgesInOrder.size());
this.streamOutputs = new RecordWriterOutput<?>[outEdgesInOrder.size()];
- this.finishedOnRestore = finishedOnRestore;
+ this.finishedOnRestoreInput =
+ this.isFinishedOnRestore()
Review comment:
Very thanks for the explanation! if we used it in the constructor we indeed could not postpone the initialization into the subclass. I also agree with that we could leave it for a future improvement~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16774: [FLINK-23708][FLINK-23698][task] Re emit and pass watermarks in finished on restore tasks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16774:
URL: https://github.com/apache/flink/pull/16774#issuecomment-896341071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9350617201c44f8c3a1e0a2c3392bc78cf10b17f",
"triggerType" : "PUSH"
}, {
"hash" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21858",
"triggerID" : "afbaed01f0574836eea2ef7cade1b4190e34c0cb",
"triggerType" : "PUSH"
}, {
"hash" : "323619080781e229f661b10f201ccbe370cb0a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21856",
"triggerID" : "323619080781e229f661b10f201ccbe370cb0a04",
"triggerType" : "PUSH"
}, {
"hash" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21885",
"triggerID" : "5e6e5bfa02a1099a1ac3540ad87247345f1a554b",
"triggerType" : "PUSH"
}, {
"hash" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890",
"triggerID" : "d20417bc277358f2fd2fa44cc0a74fcc97d4447f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9350617201c44f8c3a1e0a2c3392bc78cf10b17f UNKNOWN
* d20417bc277358f2fd2fa44cc0a74fcc97d4447f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21890)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org