You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "vanshuhassija (via GitHub)" <gi...@apache.org> on 2023/10/17 06:50:05 UTC

[PR] What changes were proposed in this pull request? [ambari]

vanshuhassija opened a new pull request, #3760:
URL: https://github.com/apache/ambari/pull/3760

   PhantomJS is a headless web browser scriptable with JavaScript. The package is no longer maintained and does not even support ES6 features of Javascript. Chrome launched ChromeHeadless which works very similar to PhantomJs. The fix will require Karma to use ChromeHeadless as the web browser instead of PhantomJs
   
   How was this patch tested?
   Ran test cases for ambari-web and it gives the desired reports.
   
   Please review Ambari Contributing Guide before opening a pull request.
   
   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2283203841

   @arshadmohammad I apologize for the slip of the tongue earlier, I meant Chromium browser, not PhantomJS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2282960770

   @arshadmohammad I remember you previously handled a PR related to PhantomJS. Have you already installed PhantomJS in the Ambari Jenkins environment? Can you explain the PhantomJS environment configuration work you did before? The frontend team needs to move forward, and we need to install PhantomJS in the Jenkins environment."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2283201493

   This PR had removed the PhantomJS. No CI change was done for this PR.  
   As far as I know, PhantomJS is automatically downloaded while building the ambari. No sure if there is specific setting required for PhantomJS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "vanshuhassija (via GitHub)" <gi...@apache.org>.
vanshuhassija commented on code in PR #3760:
URL: https://github.com/apache/ambari/pull/3760#discussion_r1387496742


##########
ambari-web/karma.conf.js:
##########
@@ -167,7 +168,7 @@ module.exports = function(config) {
     // - Opera (has to be installed with `npm install karma-opera-launcher`)
     // - Safari (only Mac; has to be installed with `npm install karma-safari-launcher`)
     // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`)
-    browsers: ['PhantomJS'],
+    browsers: ['ChromeHeadless'],

Review Comment:
   Headless browser changes are done for ambari-admin by replacing phantomjs with chromeHeadless but in case of capacity-scheduler the use case of phantomjs is different and cannot be mapped to chromeHeadless so changes are done in capacity scheduler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad merged PR #3760:
URL: https://github.com/apache/ambari/pull/3760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on code in PR #3760:
URL: https://github.com/apache/ambari/pull/3760#discussion_r1362558503


##########
ambari-web/karma.conf.js:
##########
@@ -167,7 +168,7 @@ module.exports = function(config) {
     // - Opera (has to be installed with `npm install karma-opera-launcher`)
     // - Safari (only Mac; has to be installed with `npm install karma-safari-launcher`)
     // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`)
-    browsers: ['PhantomJS'],
+    browsers: ['ChromeHeadless'],

Review Comment:
   Make similar changes in other UI containing projects like ambari-admin, contrib\views\commons, contrib\views\files, contrib\views\capacity-scheduler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2290259475

   @arshadmohammad @vanshuhassija Thank you for the information you provided. I wrote a Jenkins script to test whether the Jenkins environment has Chromium, and the conclusion is that it doesn't. You can find the script at https://github.com/apache/ambari/pull/3810. I have already submitted an issue to the ASF infra team, and we're now waiting for them to process it and install Chromium in the Jenkins environment.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2283226916

   No CI change was done for Chromium browser. 
   @vanshuhassija do you have anything to share on what packages need to be installed on CI environment for Chromium browser.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "vanshuhassija (via GitHub)" <gi...@apache.org>.
vanshuhassija commented on PR #3760:
URL: https://github.com/apache/ambari/pull/3760#issuecomment-2287022701

   @arshadmohammad @JiaLiangC No CI changes were done for ChromeHeadless. The CI ran as expected without defining custom ChromeHeadless sandbox behaviour. Simply specifying ChromeHeadless as the browser worked for me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-25985 Remove phantomjs headless browser [ambari]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on code in PR #3760:
URL: https://github.com/apache/ambari/pull/3760#discussion_r1387501004


##########
ambari-web/karma.conf.js:
##########
@@ -167,7 +168,7 @@ module.exports = function(config) {
     // - Opera (has to be installed with `npm install karma-opera-launcher`)
     // - Safari (only Mac; has to be installed with `npm install karma-safari-launcher`)
     // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`)
-    browsers: ['PhantomJS'],
+    browsers: ['ChromeHeadless'],

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org