You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ut...@apache.org on 2024/12/04 10:05:27 UTC

(airflow) 14/39: #43252 Disable extra links button if link is null or empty (#43844) (#43851)

This is an automated email from the ASF dual-hosted git repository.

utkarsharma pushed a commit to branch sync_2-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit f5142a2bd41cda0360e0bec5147a359ab9da7de9
Author: Jens Scheffler <95...@users.noreply.github.com>
AuthorDate: Sat Nov 9 19:54:03 2024 +0100

    #43252 Disable extra links button if link is null or empty (#43844) (#43851)
    
    * Disable button if link is null or empty
    
    * Fix space
    
    ---------
    
    Co-authored-by: Enis Nazif <en...@Eniss-MacBook-Pro.local>
    (cherry picked from commit de8818270095d9f05edfec8e03daa5df7d6a773b)
    
    Co-authored-by: enisnazif <en...@gmail.com>
---
 airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
index 06528eab6e7..1eb59cb9b1a 100644
--- a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
+++ b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
@@ -55,7 +55,7 @@ const ExtraLinks = ({
 
   const isSanitised = (url: string | null) => {
     if (!url) {
-      return true;
+      return false; // Empty or null urls should cause the link to be disabled
     }
     const urlRegex = /^(https?:)/i;
     return urlRegex.test(url);