You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2017/03/14 18:13:13 UTC
asterixdb git commit: Eliminate Unnecessary printStackTrace() Calls
Repository: asterixdb
Updated Branches:
refs/heads/master 04075533a -> 11cbe1f2d
Eliminate Unnecessary printStackTrace() Calls
Stacktraces flood test logs for expected exceptions. This change
suppresses stacktraces in these instances.
Change-Id: Ie0239010579a495a42b68c1f3cf19e8b03f72eee
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1578
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/11cbe1f2
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/11cbe1f2
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/11cbe1f2
Branch: refs/heads/master
Commit: 11cbe1f2d63afeb57bf1b31ba8d8ee7175e2c20b
Parents: 0407553
Author: Michael Blow <mb...@apache.org>
Authored: Tue Mar 14 12:04:38 2017 -0400
Committer: Michael Blow <mb...@apache.org>
Committed: Tue Mar 14 11:09:55 2017 -0700
----------------------------------------------------------------------
.../test/java/org/apache/asterix/test/common/TestExecutor.java | 6 +++---
.../java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/11cbe1f2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index 9a3de14..5bcad8c 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -900,7 +900,7 @@ public class TestExecutor {
} catch (Exception e) {
// An exception is expected.
failed = true;
- e.printStackTrace();
+ System.err.println("testFile " + testFile.toString() + " raised an exception: " + e);
}
if (!failed) {
throw new Exception("Test \"" + testFile + "\" FAILED!\n An exception" + "is expected.");
@@ -928,7 +928,7 @@ public class TestExecutor {
} catch (Exception e) {
// expected error happens
failed = true;
- e.printStackTrace();
+ System.err.println("testFile " + testFile.toString() + " raised an exception: " + e);
}
if (!failed) {
throw new Exception("Test \"" + testFile + "\" FAILED!\n An exception is expected.");
@@ -1219,7 +1219,7 @@ public class TestExecutor {
System.err.println("...Unexpected!");
Exception e = new Exception(
"Test \"" + cUnit.getName() + "\" FAILED!\nExpected error was not thrown...");
- e.printStackTrace();
+ System.err.println(e);
throw e;
} else if (numOfFiles == testFileCtxs.size()) {
LOGGER.info("[TEST]: " + testCaseCtx.getTestCase().getFilePath() + "/" + cUnit.getName()
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/11cbe1f2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
index 0789fa0..da8f810 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
@@ -91,9 +91,9 @@ public class ParserTestExecutor extends TestExecutor {
"[TEST]: " + testCaseCtx.getTestCase().getFilePath() + "/" + cUnit.getName() + " PASSED ");
queryCount++;
} catch (Exception e) {
- System.err.println("testFile " + testFile.toString() + " raised an exception:");
- e.printStackTrace();
+ System.err.println("testFile " + testFile.toString() + " raised an exception: " + e);
if (cUnit.getExpectedError().isEmpty()) {
+ e.printStackTrace();
System.err.println("...Unexpected!");
if (failedGroup != null) {
failedGroup.getTestCase().add(testCaseCtx.getTestCase());