You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/04/04 00:23:55 UTC
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19683
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
IMPALA-12037: Update Chart.js to 2.9.4
Updates Chart.js to 2.9.4 for bug fixes and to avoid prototype
pollution. Added Chart.min.js from
https://github.com/chartjs/Chart.js/releases/tag/v2.9.4. Moment.js from
bundle does not seem to be needed.
Chart.js 2.8 introduced https://github.com/chartjs/Chart.js/issues/6154,
which causes the last X-axis label with "and above" to always be
omitted. Add a custom autofit function to calculate our own spacing.
Testing:
- Examined /admission page with multiple queries admitted. Graph appears
to render correctly.
Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
---
D www/Chart-2.7.3.min.js
A www/Chart-2.9.4.min.js
M www/admission_controller.tmpl
3 files changed, 47 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/19683/1
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 16:04:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19683/1/www/admission_controller.tmpl
File www/admission_controller.tmpl:
http://gerrit.cloudera.org:8080/#/c/19683/1/www/admission_controller.tmpl@109
PS1, Line 109: //
> Could you add a comment for this function as workaround for the issue intro
Done
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:21:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19683
to look at the new patch set (#2).
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
IMPALA-12037: Update Chart.js to 2.9.4
Updates Chart.js to 2.9.4 for bug fixes and to avoid prototype
pollution. Added Chart.min.js from
https://github.com/chartjs/Chart.js/releases/tag/v2.9.4. Moment.js from
bundle does not seem to be needed.
Chart.js 2.8 introduced https://github.com/chartjs/Chart.js/issues/6154,
which causes the last X-axis label with "and above" to always be
omitted. Add a custom autofit function to calculate our own spacing.
Testing:
- Examined /admission page with multiple queries admitted. Graph appears
to render correctly.
Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
---
D www/Chart-2.7.3.min.js
A www/Chart-2.9.4.min.js
M www/admission_controller.tmpl
3 files changed, 48 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/19683/2
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 17:23:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12738/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 00:44:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
IMPALA-12037: Update Chart.js to 2.9.4
Updates Chart.js to 2.9.4 for bug fixes and to avoid prototype
pollution. Added Chart.min.js from
https://github.com/chartjs/Chart.js/releases/tag/v2.9.4. Moment.js from
bundle does not seem to be needed.
Chart.js 2.8 introduced https://github.com/chartjs/Chart.js/issues/6154,
which causes the last X-axis label with "and above" to always be
omitted. Add a custom autofit function to calculate our own spacing.
Testing:
- Examined /admission page with multiple queries admitted. Graph appears
to render correctly.
Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Reviewed-on: http://gerrit.cloudera.org:8080/19683
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
D www/Chart-2.7.3.min.js
A www/Chart-2.9.4.min.js
M www/admission_controller.tmpl
3 files changed, 48 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12752/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:41:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9202/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 17:24:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 22:39:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19683/1/www/admission_controller.tmpl
File www/admission_controller.tmpl:
http://gerrit.cloudera.org:8080/#/c/19683/1/www/admission_controller.tmpl@109
PS1, Line 109: //
Could you add a comment for this function as workaround for the issue introduced in Chart.js 2.8? Later we may remove it if the issue is fixed in a future version.
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 04:53:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12037: Update Chart.js to 2.9.4
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19683 )
Change subject: IMPALA-12037: Update Chart.js to 2.9.4
......................................................................
Patch Set 2: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/19683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e0da58755b9561ddc75c217ef227a81c80a2a6
Gerrit-Change-Number: 19683
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 17:22:02 +0000
Gerrit-HasComments: No