[GitHub] [inlong] featzhang commented on a diff in pull request #7741: [INLONG-7730][Manager] Support node management for Redis

["featzhang (via GitHub)" <gi...@apache.org>]

featzhang commented on code in PR #7741:
URL: https://github.com/apache/inlong/pull/7741#discussion_r1155562495


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/redis/RedisDataNodeInfo.java:
##########
@@ -36,6 +37,42 @@
 @ApiModel("Redis data node info")
 public class RedisDataNodeInfo extends DataNodeInfo {
 
+    /**
+     * Redis cluster mode
+     */
+    @ApiModelProperty(value = "Redis cluster mode")
+    private String clusterMode;
+
+    /**
+     * Redis host
+     */
+    @ApiModelProperty(value = "Redis host")
+    private String host;
+
+    /**
+     * Redis port
+     */
+    @ApiModelProperty(value = "Redis port")
+    private Integer port;
+
+    /**
+     * Redis sentinel master name
+     */
+    @ApiModelProperty(value = "Redis sentinel master name")
+    private String sentinelMasterName;
+
+    /**
+     * Redis sentinel info
+     */
+    @ApiModelProperty(value = "Redis sentinel info")
+    private String sentinelsInfo;

Review Comment:
   The word `sentinelsInfo` refers to the method used in the apache bahir flink project:
   
   `https://github.com/apache/bahir-flink/blob/release-1.1/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/descriptor/RedisValidator.java#L31`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org