[jira] [Commented] (HIVE-14948) properly handle special characters in identifiers

["Eugene Koifman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690935#comment-15690935 ] 

Eugene Koifman commented on HIVE-14948:
---------------------------------------

Some notes:
http://stackoverflow.com/questions/5832412/compiling-an-ast-back-to-source-code/5834775#5834775

      HiveParser.Identifier/HiveParser.StringLiteral/HiveParser.QuotedIdentifier
      BaseSemanticAnalyzer.escapeSQLString()/unescapeSQLString()/unescapeIdentifier()
      HiveUtils.unparseIdentifier()
      SemanticAnalyzer.unparseExprForValuesClause()
      UnparseTranslator.addIdentifierTranslation()/SubQueryDiagnostic.java
      StringEscapeUtils.escapeJava()

getMatchedText() looses `` but retains ''.  Any \\t turns to \t


> properly handle special characters in identifiers
> -------------------------------------------------
>
>                 Key: HIVE-14948
>                 URL: https://issues.apache.org/jira/browse/HIVE-14948
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-14948.01.patch
>
>
> The treatment of quoted identifiers in HIVE-14943 is inconsistent.  Need to clean this up and if possible only quote those identifiers that need to be quoted in the generated SQL statement



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)