You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/07 13:08:41 UTC

[GitHub] [pulsar] zymap opened a new pull request, #16443: [fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages

zymap opened a new pull request, #16443:
URL: https://github.com/apache/pulsar/pull/16443

   ### Motivation
   
   The RawReader hasMessageAvailable will return true when all the
   messages have been consumed. And that will cause the readNextAsync
   blocked and the process never recovered.
   In the ConsumerImpl, we update the lastDequeuedMessageId in the
   messageProcess. The messageReceived method rewrites by the RawReader,
   we should update the lastDequeuedMessageId in the RawReader as well.
   
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #16443: [fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages

Posted by GitBox <gi...@apache.org>.
zymap commented on PR #16443:
URL: https://github.com/apache/pulsar/pull/16443#issuecomment-1182737883

   ping @hangc0276. Fixed that issue. PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap merged pull request #16443: [fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages

Posted by GitBox <gi...@apache.org>.
zymap merged PR #16443:
URL: https://github.com/apache/pulsar/pull/16443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16443: [fix][pulsar-broker] Fix RawReader hasMessageAvailable returns true when no messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16443:
URL: https://github.com/apache/pulsar/pull/16443#issuecomment-1177587906

   @zymap Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org