You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:10:42 UTC
[GitHub] [hadoop] amahussein opened a new pull request #2631: HADOOP-17079. [branch-2.10] Optimize UGI#getGroups by adding UGI#getGroupsSet
amahussein opened a new pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631
Porting to Hadoop-2.10 three commits related to Groups.
HADOOP-13965. Groups should be consistent in using default group mapp… [383aa9c](https://github.com/apache/hadoop/commit/383aa9c9f55983cdb1c225b2ed22f6f48616cb9c)
HDFS-13723. Occasional "Should be different group" error in TestRefre… [162228e](https://github.com/apache/hadoop/commit/162228e8db937d4bdb9cf61d15ed555f1c96368f)
HADOOP-17079. Optimize UGI#getGroups by adding UGI#getGroupsSet. [f91a8ad](https://github.com/apache/hadoop/commit/f91a8ad88b00b50231f1ae3f8820a25c963bb561) (#2085)
CC: @linyiqun @smengcl @xiaoyuyao @jojochuang @jbrennan333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-765034981
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 19 new or modified test files. |
||| _ branch-2.10 Compile Tests _ |
| +0 :ok: | mvndep | 2m 11s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 14m 26s | branch-2.10 passed |
| +1 :green_heart: | compile | 13m 10s | branch-2.10 passed |
| +1 :green_heart: | checkstyle | 2m 21s | branch-2.10 passed |
| +1 :green_heart: | mvnsite | 6m 44s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 5m 30s | branch-2.10 passed |
| +0 :ok: | spotbugs | 2m 0s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 10m 55s | branch-2.10 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 30s | the patch passed |
| +1 :green_heart: | compile | 12m 30s | the patch passed |
| -1 :x: | javac | 12m 30s | root generated 1 new + 1541 unchanged - 0 fixed = 1542 total (was 1541) |
| -0 :warning: | checkstyle | 2m 25s | root: The patch generated 2 new + 1197 unchanged - 16 fixed = 1199 total (was 1213) |
| +1 :green_heart: | mvnsite | 6m 34s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 5m 32s | the patch passed |
| -1 :x: | findbugs | 2m 41s | hadoop-common-project/hadoop-common generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 14s | hadoop-common in the patch failed. |
| -1 :x: | unit | 65m 18s | hadoop-hdfs in the patch failed. |
| +1 :green_heart: | unit | 5m 3s | hadoop-hdfs-httpfs in the patch passed. |
| -1 :x: | unit | 18m 15s | hadoop-hdfs-rbf in the patch failed. |
| -1 :x: | unit | 67m 48s | hadoop-yarn-server-resourcemanager in the patch failed. |
| +1 :green_heart: | unit | 4m 37s | hadoop-mapreduce-client-hs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. |
| | | 290m 12s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 630] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 629] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.conf; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 632] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 340] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 533] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapCxtFactoryClass; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 613] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 750] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 503] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 346] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 398] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 399] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 496] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 618] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 485] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 485] |
| Failed junit tests | hadoop.security.TestGroupsCaching |
| | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
| | hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
| | hadoop.hdfs.server.federation.router.TestRouterQuota |
| | hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat |
| | hadoop.hdfs.server.federation.resolver.order.TestLocalResolver |
| | hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver |
| | hadoop.yarn.server.resourcemanager.TestClientRMService |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux da51df9ebb6b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / e48b91c |
| Default Java | Oracle Corporation-1.7.0_95-b00 |
| javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/diff-compile-javac-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/diff-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/whitespace-eol.txt |
| findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/testReport/ |
| Max. process+thread count | 2452 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-952344979
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 9m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. |
||| _ branch-2.10 Compile Tests _ |
| +0 :ok: | mvndep | 2m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 30s | branch-2.10 passed |
| +1 :green_heart: | compile | 13m 2s | branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | compile | 10m 44s | branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | checkstyle | 2m 9s | branch-2.10 passed |
| +1 :green_heart: | mvnsite | 6m 2s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 5m 28s | branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 4m 32s | branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +0 :ok: | spotbugs | 28m 21s | Both FindBugs and SpotBugs are enabled, using SpotBugs. |
| -1 :x: | spotbugs | 2m 1s | hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings. |
| -1 :x: | spotbugs | 2m 31s | hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 44s | the patch passed |
| +1 :green_heart: | compile | 12m 20s | the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10 |
| -1 :x: | javac | 12m 20s | root-jdkAzulSystems,Inc.-1.7.0_262-b10 with JDK Azul Systems, Inc.-1.7.0_262-b10 generated 79 new + 1676 unchanged - 3 fixed = 1755 total (was 1679) |
| +1 :green_heart: | compile | 10m 39s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| -1 :x: | javac | 10m 39s | root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 generated 79 new + 1569 unchanged - 3 fixed = 1648 total (was 1572) |
| +1 :green_heart: | checkstyle | 2m 9s | root: The patch generated 0 new + 764 unchanged - 6 fixed = 764 total (was 770) |
| +1 :green_heart: | mvnsite | 5m 52s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 5m 29s | the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 4m 32s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| -1 :x: | spotbugs | 2m 12s | hadoop-common-project/hadoop-common generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) |
||| _ Other Tests _ |
| -1 :x: | unit | 8m 4s | hadoop-common in the patch failed. |
| -1 :x: | unit | 63m 8s | hadoop-hdfs in the patch failed. |
| +1 :green_heart: | unit | 4m 32s | hadoop-hdfs-httpfs in the patch passed. |
| +1 :green_heart: | unit | 17m 26s | hadoop-hdfs-rbf in the patch passed. |
| -1 :x: | unit | 79m 32s | hadoop-yarn-server-resourcemanager in the patch failed. |
| +1 :green_heart: | unit | 3m 47s | hadoop-mapreduce-client-hs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. |
| | | 316m 46s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 595] |
| Failed junit tests | hadoop.log.TestLogLevel |
| | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle |
| uname | Linux 4b781b709a09 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / 3dd8880 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| spotbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html |
| spotbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html |
| javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/diff-compile-javac-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt |
| javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10.txt |
| spotbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/new-spotbugs-hadoop-common-project_hadoop-common.html |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/testReport/ |
| Max. process+thread count | 2702 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17079. [branch-2.10] Optimize UGI#getGroups by adding UGI#getGroupsSet
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-764008495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17079. [branch-2.10] Optimize UGI#getGroups by adding UGI#getGroupsSet
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-764008495
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. |
||| _ branch-2.10 Compile Tests _ |
| +0 :ok: | mvndep | 2m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 14m 53s | branch-2.10 passed |
| +1 :green_heart: | compile | 13m 24s | branch-2.10 passed |
| +1 :green_heart: | checkstyle | 2m 21s | branch-2.10 passed |
| +1 :green_heart: | mvnsite | 6m 54s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 5m 18s | branch-2.10 passed |
| +0 :ok: | spotbugs | 2m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 11m 6s | branch-2.10 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 39s | the patch passed |
| +1 :green_heart: | compile | 12m 55s | the patch passed |
| -1 :x: | javac | 12m 55s | root generated 79 new + 1531 unchanged - 3 fixed = 1610 total (was 1534) |
| +1 :green_heart: | checkstyle | 2m 18s | root: The patch generated 0 new + 1008 unchanged - 11 fixed = 1008 total (was 1019) |
| +1 :green_heart: | mvnsite | 6m 30s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 5m 27s | the patch passed |
| -1 :x: | findbugs | 2m 45s | hadoop-common-project/hadoop-common generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 18s | hadoop-common in the patch failed. |
| -1 :x: | unit | 63m 3s | hadoop-hdfs in the patch failed. |
| +1 :green_heart: | unit | 5m 0s | hadoop-hdfs-httpfs in the patch passed. |
| -1 :x: | unit | 17m 55s | hadoop-hdfs-rbf in the patch failed. |
| -1 :x: | unit | 67m 22s | hadoop-yarn-server-resourcemanager in the patch failed. |
| +1 :green_heart: | unit | 4m 24s | hadoop-mapreduce-client-hs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 287m 31s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 631] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 630] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.conf; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 633] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 340] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 534] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapCxtFactoryClass; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 614] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 751] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 504] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 346] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 398] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 399] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 497] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 619] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 486] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 486] |
| Failed junit tests | hadoop.security.TestLdapGroupsMappingWithOneQuery |
| | hadoop.security.TestLdapGroupsMapping |
| | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
| | hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
| | hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver |
| | hadoop.hdfs.server.federation.resolver.order.TestLocalResolver |
| | hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat |
| | hadoop.hdfs.server.federation.router.TestRouterQuota |
| | hadoop.yarn.server.resourcemanager.TestClientRMService |
| | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux d6ad7d8e5ff3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / ea3c3d9 |
| Default Java | Oracle Corporation-1.7.0_95-b00 |
| javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/diff-compile-javac-root.txt |
| findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/testReport/ |
| Max. process+thread count | 2622 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-764886532
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 10s | https://github.com/apache/hadoop/pull/2631 does not apply to branch-2.10. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-827278391
`Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]`
Was this caused by this PR or was it already there before/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-765322542
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 11m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. |
||| _ branch-2.10 Compile Tests _ |
| +0 :ok: | mvndep | 2m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 15m 4s | branch-2.10 passed |
| +1 :green_heart: | compile | 13m 39s | branch-2.10 passed |
| +1 :green_heart: | checkstyle | 2m 18s | branch-2.10 passed |
| +1 :green_heart: | mvnsite | 6m 30s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 5m 9s | branch-2.10 passed |
| +0 :ok: | spotbugs | 2m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 11m 42s | branch-2.10 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 45s | the patch passed |
| +1 :green_heart: | compile | 12m 53s | the patch passed |
| -1 :x: | javac | 12m 53s | root generated 79 new + 1531 unchanged - 3 fixed = 1610 total (was 1534) |
| +1 :green_heart: | checkstyle | 2m 17s | root: The patch generated 0 new + 983 unchanged - 8 fixed = 983 total (was 991) |
| +1 :green_heart: | mvnsite | 6m 16s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 5m 19s | the patch passed |
| -1 :x: | findbugs | 2m 46s | hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 3s | hadoop-common in the patch passed. |
| -1 :x: | unit | 68m 53s | hadoop-hdfs in the patch failed. |
| +1 :green_heart: | unit | 4m 51s | hadoop-hdfs-httpfs in the patch passed. |
| -1 :x: | unit | 18m 23s | hadoop-hdfs-rbf in the patch failed. |
| -1 :x: | unit | 70m 52s | hadoop-yarn-server-resourcemanager in the patch failed. |
| +1 :green_heart: | unit | 4m 37s | hadoop-mapreduce-client-hs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
| | | 298m 40s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596] |
| | Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 595] |
| Failed junit tests | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
| | hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
| | hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver |
| | hadoop.hdfs.server.federation.resolver.order.TestLocalResolver |
| | hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat |
| | hadoop.hdfs.server.federation.router.TestRouterQuota |
| | hadoop.yarn.server.resourcemanager.TestClientRMService |
| | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 5403b5396972 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / e48b91c |
| Default Java | Oracle Corporation-1.7.0_95-b00 |
| javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/diff-compile-javac-root.txt |
| findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/testReport/ |
| Max. process+thread count | 2633 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] amahussein commented on pull request #2631: HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Posted by GitBox <gi...@apache.org>.
amahussein commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-827562798
> `Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]`
> Was this caused by this PR or was it already there before/
I think this PR added `public Set<String> getGroupsSet(String user)` in line [LdapGroupsMapping#627](https://github.com/apache/hadoop/pull/2631/files#diff-34cbaed59eb28984bdb38185b850527c6bc2088d2295fee6657333084aeab668R627) that is not synchronized which in turn calls `doGetGroups()`. Perhaps this is why `findbugs` finds it a concurrency issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org