You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2011/09/17 02:31:09 UTC
[jira] [Created] (ZOOKEEPER-1190) ant package is not including many
of the bin scripts in the package (zkServer.sh for example)
ant package is not including many of the bin scripts in the package (zkServer.sh for example)
---------------------------------------------------------------------------------------------
Key: ZOOKEEPER-1190
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
Project: ZooKeeper
Issue Type: Bug
Components: build
Affects Versions: 3.4.0, 3.5.0
Reporter: Patrick Hunt
Priority: Blocker
Fix For: 3.4.0, 3.5.0
run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117716#comment-13117716 ]
Hadoop QA commented on ZOOKEEPER-1190:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497053/ZOOKEEPER-1190.patch
against trunk revision 1177432.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/597//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/597//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/597//console
This message is automatically generated.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Eric Yang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115022#comment-13115022 ]
Eric Yang commented on ZOOKEEPER-1190:
--------------------------------------
Does maven change come as part of 3.4.0 or 3.5.0? If maven comes in 3.4.0, then I would recommend to close this as "later". If maven comes in 3.5.0, then I would recommend to have multiple build targets in build.xml for separation of source tarball and binary artifacts and change the summary of this jira to "separation of source tarball layout and binary artifacts".
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106968#comment-13106968 ]
Eric Yang commented on ZOOKEEPER-1190:
--------------------------------------
System related script has moved to sbin. In ZOOKEEPER-999, we make separation between system scripts and user scripts. zkServer.sh is one of the script that moved to sbin. zkEnv.sh is moved to lib exec. See HADOOP-6255 on the directory layout change proposal.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117398#comment-13117398 ]
Patrick Hunt commented on ZOOKEEPER-1190:
-----------------------------------------
Regardless of maven, IMO we should not be mixing "release artifact" semantics with "packaging" semantics. I'd like to see our release artifact be pkging agnostic, and have the pkging code (regardless if it's our own or someone elses (ie Thomas's Debian, CDH, Bigtop, etc...) pull from the source (release artifact) locations.
Can you create a patch for this in 3.4.0?
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121834#comment-13121834 ]
Hudson commented on ZOOKEEPER-1190:
-----------------------------------
Integrated in ZooKeeper-trunk #1325 (See [https://builds.apache.org/job/ZooKeeper-trunk/1325/])
ZOOKEEPER-1190. ant package is not including many of the bin scripts in the package (zkServer.sh for example) (Eric Yang via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179371
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkEnv.sh
* /zookeeper/trunk/build.xml
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190-1.patch, ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Eric Yang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117466#comment-13117466 ]
Eric Yang commented on ZOOKEEPER-1190:
--------------------------------------
bq. Can you create a patch for this in 3.4.0?
I will target for 3.4.0.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1190) ant package is not including many
of the bin scripts in the package (zkServer.sh for example)
Posted by "Eric Yang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated ZOOKEEPER-1190:
---------------------------------
Attachment: ZOOKEEPER-1190.patch
* Restore "package" to release tarball
* Added "bin-package" target for making binary package layout.
* Modified zkEnv.sh to detect the running layout.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121598#comment-13121598 ]
Hadoop QA commented on ZOOKEEPER-1190:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497917/ZOOKEEPER-1190-1.patch
against trunk revision 1179371.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/606//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/606//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/606//console
This message is automatically generated.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190-1.patch, ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1190:
---------------------------------------
Assignee: Eric Yang
I'm guessing it's the recent pkging changes - Eric would you mind triaging?
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123430#comment-13123430 ]
Hudson commented on ZOOKEEPER-1190:
-----------------------------------
Integrated in ZooKeeper-trunk #1327 (See [https://builds.apache.org/job/ZooKeeper-trunk/1327/])
ZOOKEEPER-1190. ant package is not including many of the bin scripts in the package (zkServer.sh for example) (Eric Yang via phunt). Part 2.
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1180217
Files :
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/contrib/build-contrib.xml
* /zookeeper/trunk/src/recipes/build-recipes.xml
* /zookeeper/trunk/src/recipes/lock/build.xml
* /zookeeper/trunk/src/recipes/queue/build.xml
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190-1.patch, ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1190) ant package is not including many
of the bin scripts in the package (zkServer.sh for example)
Posted by "Eric Yang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Yang updated ZOOKEEPER-1190:
---------------------------------
Attachment: ZOOKEEPER-1190-1.patch
Updated directory structures for contrib and recipes.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
> Attachments: ZOOKEEPER-1190-1.patch, ZOOKEEPER-1190.patch
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114924#comment-13114924 ]
Patrick Hunt commented on ZOOKEEPER-1190:
-----------------------------------------
The original intent was to have those scripts for developers and for users of the tar archive, that's why they are in bin. Using them used for other things, like packaging, is fine, but now things are a bit confused. For example the docs say bin/zkServer.sh, not sbin. It's nice that the original docs and file locations matched regardless of checking out the source or using the release tarball. Really bin vs sbin vs libexec is a packaging specific detail (one that may be different depending on the packaging type), one I would not like to enforce on the release artifact. Also, we really need to fix how releases are packaged (I've done this as part of the maven changes). We currently have a single tar release archive which contains both the source and the generated binaries. Really we should have a source artifact and separate binary artifacts (for example the way avro does things), where the binary artifacts could be tar/jars/rpm/deb/etc..
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1190) ant package is not including
many of the bin scripts in the package (zkServer.sh for example)
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117399#comment-13117399 ]
Patrick Hunt commented on ZOOKEEPER-1190:
-----------------------------------------
bq. Can you create a patch for this in 3.4.0?
if not perhaps we should back the packaging changes out of 3.4.0 and re-introduce in 3.4.1 or 3.5.0.
> ant package is not including many of the bin scripts in the package (zkServer.sh for example)
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1190
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1190
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Patrick Hunt
> Assignee: Eric Yang
> Priority: Blocker
> Fix For: 3.4.0, 3.5.0
>
>
> run "ant package" and look in the build/zookeeper-<version>/bin directory. many of the bin scripts are missing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira